OpenStack Heat

FloatingIP resource implicitly depends on too many ports

Bug #1399713 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Sergey Kraynev
OpenStack Heat 2015.1.0 "kilo"
Juno
Fix Released
Medium
Sergey Kraynev
OpenStack Heat 2014.2.3

Bug Description

Due to a typo in the fix for bug 1384114 (see after-the-fact comment on https://review.openstack.org/#/c/130176/1/heat/engine/resources/neutron/floatingip.py for details), the FloatingIP resource will now get a dependency on any RouterInterfaces connected to the Subnets to which a random subset of all of the Ports in the template are assigned.

Of course we only want to look at the Port to which the FloatingIP is bound, and take a dependency on the RouterInterfaces for its Subnet.

Zane Bitter (zaneb)
Changed in heat:
assignee: nobody → Sergey Kraynev (skraynev)
importance: Undecided → Medium
status: New → Triaged
milestone: none → kilo-1
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140272

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/140272
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=64a301c5b2555aa04fb78925ef91321bdfa2e174
Submitter: Jenkins
Branch: master

commit 64a301c5b2555aa04fb78925ef91321bdfa2e174
Author: Sergey Kraynev <email address hidden>
Date: Tue Dec 9 03:00:48 2014 -0500

    Use only FIP dependencies from graph

    This patch contains follow important changes:
     - Fix wrong parameter passsed in graph method.
     - Now we use only FIP dependencies from graph.
     - Tests were fixed according to correct logic. Previously we try to add
       router interface to FIP dependecies, when FIPAssociation was defined
       in template. It was incorrect, because in this case such dependecy
       should be added to FIPAssociation insteaf of FIP resource.

    Change-Id: I0ee15b80627783fc2a4c037060629e3c2f364b82
    Closes-Bug: #1399713

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/160808

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/160808
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1339ac20500111b3c1fa045785a0d511d5fa42df
Submitter: Jenkins
Branch: stable/juno

commit 1339ac20500111b3c1fa045785a0d511d5fa42df
Author: Sergey Kraynev <email address hidden>
Date: Tue Dec 9 03:00:48 2014 -0500

    Use only FIP dependencies from graph

    This patch contains follow important changes:
     - Fix wrong parameter passsed in graph method.
     - Now we use only FIP dependencies from graph.
     - Tests were fixed according to correct logic. Previously we try to add
       router interface to FIP dependecies, when FIPAssociation was defined
       in template. It was incorrect, because in this case such dependecy
       should be added to FIPAssociation insteaf of FIP resource.

    Change-Id: I0ee15b80627783fc2a4c037060629e3c2f364b82
    Closes-Bug: #1399713
    (cherry picked from commit 64a301c5b2555aa04fb78925ef91321bdfa2e174)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
Zane Bitter (zaneb)
tags: removed: juno-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.