FloatingIP needs a hidden dependency on Routers

[Zane Bitter]

The OS::Neutron::FloatingIP resource has an implicit dependency on any OS::Neutron::RouterGateway resources where the gateway target is the same Network on which the FloatingIP is allocated, since a Router on the Subnet containing the Port must be connected to the Gateway before a FloatingIP can be allocated to it.

However, OS::Neutron::RouterGateway has been deprecated in favour of a property on the OS::Neutron::Router resource. So we also need the same implicit dependency on Routers with the FloatingIP's network specified as the external gateway target.

This bug is for the dependency on the EXTERNAL router gateway.

(Note: this was originally reported as bug 1299259, but that morphed into a fix for a dependency on the INTERNAL router interface.)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/140273

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/140273
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=38d1b4fada3bf1f52547103a311f7ac9e27a04b4
Submitter: Jenkins
Branch: master

commit 38d1b4fada3bf1f52547103a311f7ac9e27a04b4
Author: Sergey Kraynev <email address hidden>
Date: Tue Dec 9 03:58:06 2014 -0500

    Add dependency on Router External Gateway property

    FIP has dependecy for RouterGateway resource, but it was deperecated in
    favor of Router property. So we should add corrsponding dependency for
    FIP resource.

    Change-Id: I5c45ddc96b17bb1f87188ae3e9aabf74e6e29e1d
    Closes-Bug: #1399699

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/160809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160809
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d6770de7cfd24d1cececc7c1b978df5c30028d6c
Submitter: Jenkins
Branch: stable/juno

commit d6770de7cfd24d1cececc7c1b978df5c30028d6c
Author: Sergey Kraynev <email address hidden>
Date: Tue Dec 9 03:58:06 2014 -0500

    Add dependency on Router External Gateway property

    FIP has dependecy for RouterGateway resource, but it was deperecated in
    favor of Router property. So we should add corrsponding dependency for
    FIP resource.

    Change-Id: I5c45ddc96b17bb1f87188ae3e9aabf74e6e29e1d
    Closes-Bug: #1399699
    (cherry picked from commit 38d1b4fada3bf1f52547103a311f7ac9e27a04b4)