"nova provisioning: __init__() takes exactly 3 arguments (2 given)" in testrunner health check

[Para Siva]

This is 100 % reproducible health check error, in test runner deployed in bootstack.

The test runner output is:
http://172.20.161.145:8080/v1/AUTH_2631d8bf7bbd4c07b38fa6a39c0d8e82/ticket-test-runner-test/image_test.output.log

The cloud init output is:
http://172.20.161.145:8080/v1/AUTH_2631d8bf7bbd4c07b38fa6a39c0d8e82/ticket-test-runner-test/libpng-testbed-cloud-init.log

and the upstart log is:
http://paste.ubuntu.com/9380493/

[Vincent Ladeuil (vila)]

None of the log files contains the traceback leading to this bug. That's one thing to fix.

Ironically, the bug is on the following line:

        test_bed = testbed.TestBed(conf)

which wasn't updated when the TestBed constructor signature changed to add... a logger object:

    def __init__(self, conf, logger):

So fixing the bug will also fix the missing log ;)

[Para Siva (psivaa)]

Thanks for working on this Vincent. The attached MP infact fixes *this particular bug but the health check of the test runner behaves in a way that every time someone hits the health check page, a new testbed is spawn. That would not have been intended since this will spam the cloud with testbed instances.

I haven't still figured out if a new instance is spawn every time the health-check page is hit or only if the health check fails for some reasons, for e.g. the ssh connectivity fails with the testbed instances from the test runner: http://paste.ubuntu.com/9492042/

[Vincent Ladeuil (vila)]

As mentioned on IRC, you ran into a different bug: the testbeds weren't properly cleaned up when the setup failed. An additional fix has been pushed.