[Sahara] It is impossible to assign floating IP in nova network

[Andrew Lazarev]

OS::Sahara::NodeGroupTemplate contains 'floating_ip_pool' property and documentation says 'Value must be of type neutron.network'. And heat inside contains corresponding code: "if floating_ip_pool: self.client_plugin('neutron').find_neutron_resource(...)"

So, code works in cases:
1. Nova network with auto floating IP assignment (we don't need 'floating_ip_pool' property in this case)
2. Neutron with floating IP pool (property works well in that case)

Case that doesn't work:
1. Nova network without auto floating IP assignment

In this case Sahara expects 'floating_ip_pool' to be floating IP pool ('public' in case of devstack). But Heat doesn't accept such value with error message "floating_ip_pool publicURL endpoint for network service in RegionOne region not found" (no separator between "floating_ip_pool" and message is a separate bug).

[Pavlo Shchelokovskyy (pshchelo)]

Thanks Andrey. Previous discussions with Sahara devs suggested that floating_ip_pool is needed on Neutron only, that's why we implemented a neutron network constraint on it (and thus it can not find it in case of Nova network). I will lift that constraint.

Another question then - as we probably can not assert in Heat if auto-floating-ips are ennabled in Nova-network, do you see sense in making this property required then so that the template author is always on the same side?

[Andrew Lazarev (alazarev)]

The property should not be required since it is normal situation to have cluster with no floating IPs. Also in case of nova network with floating IP auto assignment it is not needed (two floating IPs will be assigned if provided, we saw this with sahara).

I propose either just remove constraint or make it nova network/neutron dependent. And change description of course.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/141310

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/141310
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e7acfee7a8707d1e5f570bf5ce8190a24c068f0b
Submitter: Jenkins
Branch: master

commit e7acfee7a8707d1e5f570bf5ce8190a24c068f0b
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Fri Dec 12 09:27:30 2014 +0000

    Allow floating_ip_pool on Nova-net in Sahara

    This patch removes neutron.network constraint from floating_ip_pool
    property of Sahara Node Group Template resource. That allows proper
    floating ip assignment on Nova-network.

    Also validation for this property is softened, so that it is not
    required on Neutron.

    Change-Id: I1cf796c92c27947d6c23888a47f50d4601fdbb1e
    Closes-Bug: #1399469