[Sahara] default_image_id is called 'image' in OS::Sahara::Cluster

Bug #1399450 reported by Andrew Lazarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Sergey Kraynev

Bug Description

OS::Sahara::ClusterTemplate has 'default_image_id' parameter.
The same parameter in OS::Sahara::Cluster is called 'image'. This is the same parameter and it is called 'default' because it can be specified for each node group. So, this is default image for the cluster unless it is overwritten by specific node group.

So, parameter of OS::Sahara::Cluster should be called 'default_image_id'. The only concern is backward compatibility.

Probably it is good idea to add 'image' property to node group template.

Tags: sahara
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

When we rename properties we mark the old one as deprecated.

Changed in heat:
assignee: nobody → Sergey Kraynev (skraynev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/139989

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/140305

Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Medium
milestone: none → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/140305
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4aeac08bfcf105b2071da5bbff60109e8e138dfe
Submitter: Jenkins
Branch: master

commit 4aeac08bfcf105b2071da5bbff60109e8e138dfe
Author: Sergey Kraynev <email address hidden>
Date: Tue Dec 9 06:42:47 2014 -0500

    Renaming image property to default_image_id

    This renaming is necessary for corresponding sahara validation schema.
    Also some validation logic was added for new property.

    Change-Id: I156338341d3c065502f1c4dcfe5b7350598efa40
    Closes-Bug: #1399450

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/139989
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=8a27fa7431abf7b14dd9f8257d571397f4697849
Submitter: Jenkins
Branch: master

commit 8a27fa7431abf7b14dd9f8257d571397f4697849
Author: Sergey Kraynev <email address hidden>
Date: Fri Dec 5 08:54:10 2014 -0500

    Add image_id property to node group template

    Change-Id: Ifd3ee9c9a426163fd65101ef3226332567eafea7
    Partial-Bug: #1399450

Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.