Swift parameter causes inventory generator error

[Ian Cordasco]

Opened by ionosphere80 on 2014-11-18 00:34:10+00:00 at https://github.com/rcbops/ansible-lxc-rpc/issues/564

------------------------------------------------------------

The "weight" parameter in swift.yml causes the following inventory generator error:

Traceback (most recent call last):
  File "./dynamic_inventory.py", line 845, in
    main()
  File "./dynamic_inventory.py", line 811, in main
    user_defined_config
  File "./dynamic_inventory.py", line 493, in container_skel_load
    value.get('is_metal', False)
  File "./dynamic_inventory.py", line 346, in _add_container_hosts
    host_options
  File "./dynamic_inventory.py", line 263, in _append_to_host_groups
    if 'limit_container_types' in options:
TypeError: argument of type 'int' is not iterable

Tags: Backport Potential, bug, Has PR, prio:3

====================== COMMENTS ============================

Comment created by andymcc on 2014-11-18 10:22:57+00:00

@ionosphere80 can you give a link to your swift.yml?

------------------------------------------------------------

Comment created by ionosphere80 on 2014-11-18 15:28:09+00:00

Sure...

https://gist.github.com/ionosphere80/b80a48f8934d6fbbcc8f

------------------------------------------------------------

Comment created by ionosphere80 on 2014-11-18 18:52:27+00:00

I'm going to test a swift.yml example from @andymcc to see if it resolves the issue.

[Justin Shepherd (jshepher)]

if swift is the new feature in 10.1.0 how does this have backport potential?

[Kevin Carter (kevin-carter)]

This is not a "backport potential" issue. the generator type error was addressed in this PR https://review.openstack.org/#/c/139245/.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/139245
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=1710987f0a1d7e170e1d8e441f65742c645fa398
Submitter: Jenkins
Branch: master

commit 1710987f0a1d7e170e1d8e441f65742c645fa398
Author: Kevin Carter <email address hidden>
Date: Tue Nov 18 17:27:50 2014 -0600

    Fixed generator type assumption error

    When adding the swift config pieces the dynamic inventory has attempts
    to add extra arguments to host _meta inventory which assumes the option
    is in a dictionary format. To address the issue an if block has been
    added which which checks the object type and proceeds accordingly.

    Closes-Bug: 1399387
    Change-Id: I0203dc525ca9e8f962ac683ca07b5cb3bea41589

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: juno
Review: https://review.openstack.org/148958

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: icehouse
Review: https://review.openstack.org/148959

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/148958
Reason: This patch can't be added individually in this branch - it needs to be squashed with other patches which combined together get gating working.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: icehouse
Review: https://review.openstack.org/148959
Reason: This patch can't be added individually in this branch - it needs to be squashed with other patches which combined together get gating working.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: juno
Review: https://review.openstack.org/149230

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: I made a mistake with the commit message.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/149209
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=e01165bcc729ba151473dfe3199f913906e8d4b9
Submitter: Jenkins
Branch: juno

commit e01165bcc729ba151473dfe3199f913906e8d4b9
Author: Jesse Pretorius <email address hidden>
Date: Mon Jan 19 17:47:38 2015 +0000

    Squash all patches required to make gating work

    This is a merge of the following patches:
    62d2525 Fixed generator type assumption error
    1339640 Allow swift_vars to not be specified for swift_hosts
    735eb68 AIO to use https to access the frozen repo
    033df65 use archive.mariadb.org for to install mariadb package
    8b9cf6e Use reliable static mirror for mariadb apt repository
    b30f9d1 Add debootstrap package to LXC package list
    5c464e1 Add swift_all inventory to swift-common play
    a88bcb7 Add swift_all inventory to swift account/container/object plays

    Change-Id: I630e38b35a00fe547ec3aaa68604a5902be4f83e
    Closes-Bug: #1399387
    Closes-Bug: #1406323
    Closes-Bug: #1399387
    Closes-Bug: #1402582
    Closes-Bug: #1402594
    Closes-Bug: #1402617
    Closes-Bug: #1409762
    Closes-Bug: #1410743
    Closes-Bug: #1411331
    Closes-Bug: #1412521

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: icehouse
Review: https://review.openstack.org/149213
Reason: This patch was an investigation to figure out what needed to go into the branch in order to get the gate operational. Now that we know, we can cherry-pick the patches individually.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148959
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=12b56a6d8bc0db643d1fa68daf01a046d8e48977
Submitter: Jenkins
Branch: icehouse

commit 12b56a6d8bc0db643d1fa68daf01a046d8e48977
Author: Kevin Carter <email address hidden>
Date: Tue Nov 18 17:27:50 2014 -0600

    Fixed generator type assumption error

    When adding the swift config pieces the dynamic inventory has attempts
    to add extra arguments to host _meta inventory which assumes the option
    is in a dictionary format. To address the issue an if block has been
    added which which checks the object type and proceeds accordingly.

    Closes-Bug: #1399387
    Related-Bug: #1409762
    Change-Id: I0203dc525ca9e8f962ac683ca07b5cb3bea41589
    (cherry picked from commit 1710987f0a1d7e170e1d8e441f65742c645fa398)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148958
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=40183d68cf10895e568056cc35a92119dd66c376
Submitter: Jenkins
Branch: juno

commit 40183d68cf10895e568056cc35a92119dd66c376
Author: Kevin Carter <email address hidden>
Date: Tue Nov 18 17:27:50 2014 -0600

    Fixed generator type assumption error

    When adding the swift config pieces the dynamic inventory has attempts
    to add extra arguments to host _meta inventory which assumes the option
    is in a dictionary format. To address the issue an if block has been
    added which which checks the object type and proceeds accordingly.

    Closes-Bug: #1399387
    Related-Bug: #1409762
    Change-Id: I0203dc525ca9e8f962ac683ca07b5cb3bea41589
    (cherry picked from commit 1710987f0a1d7e170e1d8e441f65742c645fa398)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: mistaken commit

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: never mind - borked