Cinder Backup

[Ian Cordasco]

Opened by b3rnard0 on 2014-11-18 17:21:17+00:00 at https://github.com/rcbops/ansible-lxc-rpc/issues/570

------------------------------------------------------------

From @ryanyard

Customer is requesting cinder-backup be configured for their cloud, is that something we will support? If so, can you help me configure it? I have the cinder.conf directives, was wanting a recommendation on where to run, was thing inside the volume container, how do I create an upstart script for the service?

From @cloudnull :

@jcannava , @claco , is this something we want to prioritize for this sprint?

To add cinder backup to the playbooks we would need to create a role that would enable it, IE add config, start services

Config looks like it would need to be a generator that supports three possible cinder backup services. I would assume that we would only support Swift:

http://docs.openstack.org/juno/config-reference/content/swift-backup-driver.html changes would be made to the /etc/cinder/cinder.conf

Cinder backup is a service that can be started and stopped with our standard upstart script generator.

IMHO this would be an addon play that was only run if the user ran it manually as cinder-backup is still an optional service according to the upstream openstack docs.

Tags: planning, prio:3

====================== COMMENTS ============================

Comment created by b3rnard0 on 2014-11-18 17:22:37+00:00

From @claco :

Given our looming customer deadlines, and the need to solidify and stabilize what we currently have, I would much prefer that we do not go down this path at the moment. The sprint it set, and I would like to get us back into the habit of not just adding work to each sprint without it first getting reviewed and prioritized by the larger group.

I'm not apposed to adding this feature, but I am concerned that sometimes these tasks take a little more time than originally anticipated. I would like to keep us focused on getting things stable and helping QE/Support through any issues around the 10.1.0 release itself over the next few
weeks.

Having said that, please add this as a github issue. We have recently started reviewing and prioritizing open issues as a group, with both support and devs coming to agreement on what things are priority1, p2, and p3. We need to also include someone from the se group in those
meetings.

------------------------------------------------------------

Comment created by b3rnard0 on 2014-11-18 17:23:49+00:00

From @mancdaz :

I tend to agree. We are already behind on finalizing the 10.0.0 release due to some late issues that QE are finding, which we will need to prioritize. We also have a number of outstanding P1 issues that we need to get to for 10.1.0, the testing for which falls behind each day that we are
delayed on 10.0.0.

------------------------------------------------------------

Comment created by jcannava on 2014-11-19 15:33:15+00:00

+1 this needs to be prioritized in a later sprint.

[Kevin Carter (kevin-carter)]

The cinder backup agent is a tunable in master and the values to configure it can be seen here: "https://github.com/stackforge/os-ansible-deployment/blob/master/playbooks/roles/os_cinder/defaults/main.yml#L72-L89".

The issue at hand is now wether to backport that functionality to Juno/Icehouse?

[chris benson (christopher-benson)]

A customer is asking about this functionality. they are getting a 500 error when running the command.

[Darren Birkett (darren-birkett)]

@Chris Benson - what version of the deployment are they using? Currently the functionality doesn't exist in juno/icehouse deployments (oopenstack-ansible deployments that is).

I am in the process of backporting it to juno though...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: juno
Review: https://review.openstack.org/177860

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178129

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/178155

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178129
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=28e23043f9853694a5cb235f2ba0757268074ccf
Submitter: Jenkins
Branch: master

commit 28e23043f9853694a5cb235f2ba0757268074ccf
Author: Matt Thompson <email address hidden>
Date: Tue Apr 28 11:50:29 2015 +0100

    Fix cinder-backup deployment issues

    Currently, cinder-backup isn't getting deployed correctly. This commit
    fixes two of the known issues so that we correctly update cinder.conf
    on the cinder_volume hosts and also update the
    cinder_service_backup_program_name so we correctly deploy the init
    script for cinder-backup.

    Partial-bug: #1399386
    Change-Id: I18551197d5f3e6349a22e13f989b4c38ad6030af

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178564

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178155
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=a05bd53b1fb4caca64b217fbc003f025437219ae
Submitter: Jenkins
Branch: kilo

commit a05bd53b1fb4caca64b217fbc003f025437219ae
Author: Matt Thompson <email address hidden>
Date: Tue Apr 28 11:50:29 2015 +0100

    Fix cinder-backup deployment issues

    Currently, cinder-backup isn't getting deployed correctly. This commit
    fixes two of the known issues so that we correctly update cinder.conf
    on the cinder_volume hosts and also update the
    cinder_service_backup_program_name so we correctly deploy the init
    script for cinder-backup.

    Partial-bug: #1399386
    Change-Id: I18551197d5f3e6349a22e13f989b4c38ad6030af

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/178841

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/177860
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=a7387eea257d76abca28042062d8f4e6f67d2131
Submitter: Jenkins
Branch: juno

commit a7387eea257d76abca28042062d8f4e6f67d2131
Author: Darren Birkett <email address hidden>
Date: Mon Apr 27 12:10:24 2015 +0100

    Add ability to configure cinder backups

    This commit adds the configuration for the cinder-backup service to the
    cinder.conf template (specifically at this time only support for the
    swift driver is included)

    Additionally, plays are added to start the cinder-backup service on the
    cinder-volumes containers (this behaviour mirrors what is currently in
    master).

    Whilst not a cherry-pick, this work is modelled on similar work in
    master

    Partial-bug: #1399386
    Change-Id: I6f3353210277c344c191f226c2e8d11bf5822419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178564
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=e1631dbace461491c02075e1a7ff1ab1d8f4283b
Submitter: Jenkins
Branch: master

commit e1631dbace461491c02075e1a7ff1ab1d8f4283b
Author: Matt Thompson <email address hidden>
Date: Wed Apr 29 09:53:43 2015 +0100

    Update cinder.conf for cinder-backup

    This change updates the way we write cinder.conf when cinder backups
    are enabled. If cinder_service_backup_swift_auth is set to 'per_user',
    we do not set any url/user/key/tenant options in the config. However,
    if cinder_service_backup_swift_auth is set to 'single_user' then all
    auth-related options will be written. Some additional variables were
    added to allow 'single_user' to work properly.

    Note that backup_swift_url is actually the swift storage URL if using
    'per_user', or your auth URL if using 'single_user'.

    Partial-bug: #1399386
    Change-Id: Ia9d2e140d629b1f7b4c668d2f6041f3c440ab826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: juno
Review: https://review.openstack.org/179090

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178841
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=5889bdc4db167271ca59e7fff36dc8b46d89a41a
Submitter: Jenkins
Branch: kilo

commit 5889bdc4db167271ca59e7fff36dc8b46d89a41a
Author: Matt Thompson <email address hidden>
Date: Wed Apr 29 09:53:43 2015 +0100

    Update cinder.conf for cinder-backup

    This change updates the way we write cinder.conf when cinder backups
    are enabled. If cinder_service_backup_swift_auth is set to 'per_user',
    we do not set any url/user/key/tenant options in the config. However,
    if cinder_service_backup_swift_auth is set to 'single_user' then all
    auth-related options will be written. Some additional variables were
    added to allow 'single_user' to work properly.

    Note that backup_swift_url is actually the swift storage URL if using
    'per_user', or your auth URL if using 'single_user'.

    Partial-bug: #1399386
    Change-Id: Ia9d2e140d629b1f7b4c668d2f6041f3c440ab826
    (cherry picked from commit e1631dbace461491c02075e1a7ff1ab1d8f4283b)
    (cherry picked from commit cd9680e4ed4e7834ef6eafce6bdb0f7366e007a5)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179090
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=2740af3317b028c606a6f6b9081a1a7cab3644de
Submitter: Jenkins
Branch: juno

commit 2740af3317b028c606a6f6b9081a1a7cab3644de
Author: Matt Thompson <email address hidden>
Date: Thu Apr 30 14:59:00 2015 +0100

    Lower default backup_metadata_version to 1

    Kilo cinder supports both version 1 and 2, however juno cinder only
    supports version 1. Running
    tempest.api.volume.admin.test_volumes_backup against a juno cinder
    installation w/ backup_metadata_version set to 2 results in the
    following cinder-backup error being logged:

    BackupOperationError: Metadata restore failed due to incompatible
                          version

    Partial-bug: #1399386
    Change-Id: I20852c5fb331d9cbd297ecbd60a2b57d4fa37266