Add missing Core FIlter in V9 deployment Nova Playbooks

[Ian Cordasco]

Opened by cbruf82 on 2014-11-25 22:21:32+00:00 at https://github.com/rcbops/ansible-lxc-rpc/issues/652

------------------------------------------------------------

In the nova_all.yml file:

nova_scheduler_default_filters: RetryFilter,AvailabilityZoneFilter,RamFilter,ComputeFilter,CoreFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter,AggregateCoreFilter

Tags:

====================== COMMENTS ============================

Comment created by odyssey4me on 2014-11-25 22:35:03+00:00

We could, of course, add every scheduler filter into the config - thus providing the capability of any existing filter/scheduler hint to be used without further customisation. That would probably result in a bit of extra load on the DB and scheduler server though. Thoughts?

------------------------------------------------------------

Comment created by cloudnull on 2014-11-26 00:21:59+00:00

@cbruf82 while the filter was not set in the default config you can override it to be whatever you'd like. Simply set the variable nova_scheduler_default_filters as the comma separated list of filters you want in the ``/etc/rpc_deploy/user_variables.yml** file and then (re)run the nova-scheduler plays to update your configs.

Default filters set for v9.0.x: "https://github.com/rcbops/ansible-lxc-rpc/blob/1bbea028674a2b5e0278232cb74e7047f4f60c4d/rpc_deployment/inventory/group_vars/nova_all.yml#L81"

[Matt Thompson (mattt416)]

Hi Justin,

The nova_scheduler_default_filters in the original comment adds CoreFilter and removes AggregateDiskFilter. Are we adjusting the defaults across all branches to match this?

Thanks!

--Matt

[Matt Thompson (mattt416)]

We have a similar request in https://bugs.launchpad.net/openstack-ansible/+bug/1399364 asking us to add DiskFilter, trying to get an exhaustive list of the default filters required so I can make a single commit.

[Andy McCrae (andrew-mccrae)]

I'm in favour of using the nova.conf default from upstream, and then allowing the value to be adjusted via a variable.

[Matt Thompson (mattt416)]

Looks like adding CoreFilter should be unnecessary when AggregateCoreFilter is present. From http://docs.openstack.org/juno/config-reference/content/section_compute-scheduler.html:

AggregateCoreFilter

Filters host by CPU core numbers with a per-aggregate cpu_allocation_ratio value. If the per-aggregate value is not found, the value falls back to the global setting.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/141017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/141017
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=f3af86445f2aafc2b42faeb79a1bfb60cc99af0c
Submitter: Jenkins
Branch: master

commit f3af86445f2aafc2b42faeb79a1bfb60cc99af0c
Author: Matt Thompson <email address hidden>
Date: Thu Dec 11 11:15:15 2014 +0000

    Change nova scheduler filters

    This commit changes AggregateCoreFilter to CoreFilter and
    AggregateDiskFilter to DiskFilter. Whilst these filters work even if
    aggregates are not being used, icehouse does not have
    AggregateDiskFilter so there CoreFilter and DiskFilter need to be used.
    This change is more to bring the two branches in line, and if anyone
    does explicitly need the aggregate filter then that can be added via a
    local override.

    Change-Id: I6cc01139db7274f80d138020c97368a0faece771
    Closes-Bug: 1399366