Binding loop for TextView's Flickable property and deprecated code
Bug #1399266 reported by
Stefano Verzegnassi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Fix Released
|
Critical
|
Stefano Verzegnassi | ||
Bug Description
At the moment we have a TextArea inside a Flickable to allow content scrolling if it exceed TextView's page height.
It is fundamentally wrong, since TextArea already includes a Flickable.
This causes a binding loop in TextView page, since the engine is not able to assign to the "flickable" property.
We should remove the Flickable and the Column that contains TextArea, and anchor the TextArea to fill the page.
Also, we don't need anymore to explicitely manage keyboard inputs, since they are already managed by TextArea itself.
Related branches
lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-1399266
- Bartosz Kosiorek (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 128 lines (+26/-90)1 file modifiedsrc/app/qml/TextView.qml (+26/-90)
| description: | updated |
| summary: |
- TextView's Flickable has a strange behaviour + Binding loop for TextView's Flickable property and deprecate code |
| summary: |
- Binding loop for TextView's Flickable property and deprecate code + Binding loop for TextView's Flickable property and deprecated code |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-docviewer-app at revision 45, scheduled for release in ubuntu-