Running network verification on running env may break network

[Łukasz Oleś]

During network verification process 8021q module is loaded. When cluster is already installed this module may break OVS.

It should be loaded only on bootstrap image when VLANs are not configured.

https://github.com/stackforge/fuel-web/blob/master/network_checker/network_checker/net_check/api.py#L84

[Dima Shulyak (dshulyak)]

It makes more sense to use for network verification on ovs-based environments - ovs-vlan test

https://github.com/openvswitch/ovs/blob/master/python/ovstest/tests.py

We may need to modify this code for better automation though

[Dmitry Pyzhov (dpyzhov)]

We are lack of resources in 6.1

[Nastya Urlapova (aurlapova)]

Let's describe such behaviour in documents.

[Mike Scherbakov (mihgen)]

Can we have more data on how it affects end users? If it does affect users, can we have warning / ask for confirmation from a user that he want to proceed as a workaround, if we don't have time/resources to fix this in 7.0?

[Ihor Kalnytskyi (ikalnytskyi)]

Well, it looks like the first thing we have to do is:

* to check that `8021q` is loaded on bootstrap
* to check that `8021q` is loaded right after provisioning (node status is provisioned)
* to check that `8021q` is loaded after deployment

If so, we should just remove loading of `8021q` from the network checker.

[Maciej Kwiek (maciej-iai)]

`modinfo 8021q` on discovered, provisioned and deployed node says the module is loaded, so I will remove loading the module from network checker.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211525

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211525
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e91647a9cff8c0271d8cbb1181f7dd0dc5f2e411
Submitter: Jenkins
Branch: master

commit e91647a9cff8c0271d8cbb1181f7dd0dc5f2e411
Author: Maciej Kwiek <email address hidden>
Date: Tue Aug 11 14:05:23 2015 +0200

    Loading 8021q module is removed from netcheck

    Loading this module on working environment broke OVS. This module is
    loaded already on bootstrapped, provision and deployed nodes anyway, so
    there is no need for loading it again.

    Change-Id: Icfbae58b10fc1e58e183d5abac05061ae97ea282
    Closes-Bug: #1399004

[Andrey Sledzinskiy (asledzinskiy)]

{u'build_id': u'270', u'build_number': u'270', u'auth_required': True, u'fuel-ostf_sha': u'582a81ccaa1e439a3aec4b8b8f6994735de840f4', u'fuel-library_sha': u'f3780484874f5f4a1831714710ff552f33522915', u'nailgun_sha': u'9a1207d02d943953e130a0a31b9f7aa855cd44db', u'openstack_version': u'2015.1.0-7.0', u'fuel-nailgun-agent_sha': u'd7027952870a35db8dc52f185bb1158cdd3d1ebd', u'fuel-agent_sha': u'082a47bf014002e515001be05f99040437281a2d', u'api': u'1.0', u'python-fuelclient_sha': u'9643fa07f1290071511066804f962f62fe27b512', u'astute_sha': u'ad6d59812b775bc12e7bd7aec8f81374595ffa63', u'fuelmain_sha': u'9ab01caf960013dc882825dc9b0e11ccf0b81cb0', u'feature_groups': [u'mirantis'], u'release': u'7.0', u'release_versions': {u'2015.1.0-7.0': {u'VERSION': {u'build_id': u'270', u'build_number': u'270', u'fuel-library_sha': u'f3780484874f5f4a1831714710ff552f33522915', u'nailgun_sha': u'9a1207d02d943953e130a0a31b9f7aa855cd44db', u'fuel-ostf_sha': u'582a81ccaa1e439a3aec4b8b8f6994735de840f4', u'fuel-nailgun-agent_sha': u'd7027952870a35db8dc52f185bb1158cdd3d1ebd', u'fuel-agent_sha': u'082a47bf014002e515001be05f99040437281a2d', u'api': u'1.0', u'python-fuelclient_sha': u'9643fa07f1290071511066804f962f62fe27b512', u'astute_sha': u'ad6d59812b775bc12e7bd7aec8f81374595ffa63', u'fuelmain_sha': u'9ab01caf960013dc882825dc9b0e11ccf0b81cb0', u'feature_groups': [u'mirantis'], u'release': u'7.0', u'openstack_version': u'2015.1.0-7.0', u'production': u'docker'}}}, u'production': u'docker'}