SwiftSignalHandle resource ID can be too long for DB column

Bug #1398927 reported by Jason Dunsmore
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Jason Dunsmore

Bug Description

Similarly to the following RandomString bug: https://bugs.launchpad.net/heat/+bug/1392359, the SwiftSignalHandle URL can be too long for the database column, resulting in an exception:

2014-12-02 23:02:19.789 5472 ERROR oslo.db.sqlalchemy.exc_filters [-]
DBAPIError exception wrapped from (DataError) (1406, "Data too long
for column 'nova_instance' at row 1") 'UPDATE resource SET
nova_instance=%s WHERE resource.id = %s'
('https://storage101.dfw1.clouddrive.com/v1/MossoCloudFS_6046f8ab-d13a-4acc-bbf1-7d7b1255b988/3da8dce9-f72f-4f18-b5b0-c56e9af91acd/qe_kitchen_sinkDFW-tempest-1102542194-wait_handle-dkyyetnk5pe6?temp_url_sig=fe4067e7d907af8ae1ff2a117060b7808f0b03fe&temp_url_expires=2147483587', 'daaebc3e-1824-41ab-aac0-72a49c7bf5bf')

Changed in heat:
assignee: nobody → Jason Dunsmore (jasondunsmore)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138819

Changed in heat:
status: New → In Progress
Changed in heat:
importance: Undecided → Medium
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/138819
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=837a093a24ea6005f1291b954e48cb338fd5a9b4
Submitter: Jenkins
Branch: master

commit 837a093a24ea6005f1291b954e48cb338fd5a9b4
Author: Jason Dunsmore <email address hidden>
Date: Wed Dec 3 12:33:10 2014 -0600

    Use physical_resource_name to generate the resource ID

    The SwiftSignalHandle URL can be too long for the database column,
    resulting in an unhandled exception and failed stack.

    Use the SwiftSignalHandle's physical_resource_name() method to generate
    the resource ID and use FnGetRefId to fetch the handle URL instead.

    Change-Id: Iee5fc684b1f2f64ed543022a9e51612c1f80bb1e
    Closes-Bug: #1398927

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.