xenapi: upload failures causing image to go active

[John Garbutt]

There was an attempt to stop some glance errors when we have upload failures here:
https://github.com/openstack/nova/commit/e039b036b5e9dbaff8b37f7ab22c209b71bdc182

However, sending the chunk terminator makes glance thing that the failed upload has completed.

We need to make sure when the upload fails, glance puts the image into the failed state, not the active state.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/138724

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/138724
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=979d1116fe1fcae3e67974dd618854d6f66a6f5d
Submitter: Jenkins
Branch: master

commit 979d1116fe1fcae3e67974dd618854d6f66a6f5d
Author: John Garbutt <email address hidden>
Date: Tue Nov 18 14:31:34 2014 +0000

    xenapi: don't send terminating chunk on errors

    If we send the terminator on an error, it looks like we have actually
    completed the upload, when that was not actually the case, we have
    failed, and ideally we want glance to notice and mark the snapshot as
    failed.

    This partly reverts the following commit:
    e039b036b5e9dbaff8b37f7ab22c209b71bdc182

    It is not a full revert of the above commit, and some of the refactoring
    and error handling changes are still useful.

    Closes-Bug: #1398826
    Change-Id: Ib608a32556135a5b7e666d02c4ee77722ea6e07c