nova unit tests failing in the gate with "TypeError: acquire() got an unexpected keyword argument 'delay'"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Ben Nemec |
Bug Description
2014-12-02 23:31:22.547 | 542 11641 TRACE nov{1} nova.tests.
2014-12-02 23:31:22.547 |
2014-12-02 23:31:22.547 | Captured traceback:
2014-12-02 23:31:22.547 | ~~~~~~~~~~~~~~~~~~~
2014-12-02 23:31:22.547 | Traceback (most recent call last):
2014-12-02 23:31:22.547 | File "/home/
2014-12-02 23:31:22.547 | return func(*args, **keywargs)
2014-12-02 23:31:22.547 | File "nova/tests/
2014-12-02 23:31:22.547 | self.fw.
2014-12-02 23:31:22.548 | File "nova/virt/
2014-12-02 23:31:22.548 | self.refresh_
2014-12-02 23:31:22.548 | File "nova/virt/
2014-12-02 23:31:22.548 | self._do_
2014-12-02 23:31:22.548 | File "/home/
2014-12-02 23:31:22.548 | do_log=False, semaphores=
2014-12-02 23:31:22.548 | File "/usr/lib/
2014-12-02 23:31:22.548 | return self.gen.next()
2014-12-02 23:31:22.548 | File "/home/
2014-12-02 23:31:22.548 | ext_lock.
2014-12-02 23:31:22.548 | TypeError: acquire() got an unexpected keyword argument 'delay'
2014-12-02 23:31:22.549 | Traceback (most recent call last):
2014-12-02 23:31:22.549 | _StringException: Empty attachments:
2014-12-02 23:31:22.549 | stderr
2014-12-02 23:31:22.549 | stdout
1299 hits in the last 48 hours due to the oslo.concurrency 0.3.0 release today.
no longer affects: | oslo.concurrency |
Changed in nova: | |
milestone: | none → kilo-1 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | kilo-1 → 2015.1.0 |
This was the oslo.concurrency change:
https:/ /github. com/openstack/ oslo.concurrenc y/commit/ 46c836ee28aff5b fa57598971cd175 a0be0951d9
Looks like the bug is that the nova unit test is mocking out the internals of lockutils:
http:// git.openstack. org/cgit/ openstack/ nova/tree/ nova/tests/ unit/virt/ libvirt/ test_firewall. py#n359
I don't know why that's necessary, but it's wrong now since the external_lock internals of lockutils require the lock object type extends the private _FileLock object.