The API doesn't return nullable fields when they're null

Bug #1398314 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Flavio Percoco
Glance Client
Won't Fix
Medium
Flavio Percoco

Bug Description

The schema filter method removes all fields that are null from the object schema. This is causing incompatibilities from the client side and it also makes glance's responses inconsistent.

Changed in glance:
assignee: nobody → Flavio Percoco (flaper87)
Changed in glance:
status: New → In Progress
Louis Taylor (kragniz)
Changed in glance:
importance: Undecided → Medium
Changed in python-glanceclient:
importance: Undecided → Medium
assignee: nobody → Flavio Percoco (flaper87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/138184
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d17a1ed78a259789ec7d52658057ca92a6935ead
Submitter: Jenkins
Branch: master

commit d17a1ed78a259789ec7d52658057ca92a6935ead
Author: Flavio Percoco <email address hidden>
Date: Mon Dec 1 21:52:22 2014 +0100

    Allow None values to be returned from the API

    Currently, Glance's API v2 doesn't return fields whose value is None.
    This, unfortunately, is wrong for a client perspective since it would
    create inconsistencies between calls and images due to the lack of
    fields in the response.

    The API should guarantee consistency in its replies and ensure all
    fields have a value, even if it's None.

    NOTE: This work is part of the migration to v2. It fixes inconsistencies
    in the API and improves the interaction between the client library and
    Glance.

    NOTE2: A follow-up patch will bump the minor API version, wait for it.

    ApiImpact
    DocImpact
    Closes-bug: #1398314

    Change-Id: Ieaddd8a686cf7361f18cb1ee83b7887cdca22bd6

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140336

Changed in python-glanceclient:
status: New → In Progress
Louis Taylor (kragniz)
Changed in glance:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Changed in python-glanceclient:
milestone: none → v0.16.0
Louis Taylor (kragniz)
Changed in python-glanceclient:
milestone: v0.16.0 → none
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-glanceclient (master)

Change abandoned by Flavio Percoco (<email address hidden>) on branch: master
Review: https://review.openstack.org/140336
Reason: I guess this is not needed anymore now that we default to v2 and the api version w/ the schema fix is out.

Revision history for this message
Kairat Kushaev (kkushaev) wrote :

Won't fix due to Flavio's comment.

Changed in python-glanceclient:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.