Mirantis OpenStack

[Backport][bug/1386932]context.elevated: copy.copy causes admin role leak

Bug #1398031 reported by Alexander Ignatov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Committed
High
Alexander Ignatov
Mirantis OpenStack 6.0

Bug Description

This bug is filed to backport fix issue https://bugs.launchpad.net/neutron/+bug/1386932

Original description:
==================

In neutron/context.py,

```
        context = copy.copy(self)
        context.is_admin = True

        if 'admin' not in [x.lower() for x in context.roles]:
            context.roles.append('admin')
```

copy.copy should be replaced by copy.deepcopy such that the list reference is not shared between objects. From my cursory search on github this also affects cinder, gantt, nova, neutron, and manila.

Alexander Ignatov (aignatov)
Changed in mos:
importance: Undecided → High
status: Triaged → In Progress
Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package neutron has been built for project openstack/neutron
Package version == 2014.2, package release == fuel6.0.mira11.git.9cc27f5.a299407

Changeset: https://review.fuel-infra.org/1149
project: openstack/neutron
branch: openstack-ci/fuel-6.0/2014.2
author: Alexander Ignatov
committer: Alexander Ignatov
subject: Fix context.elevated
status: patchset-created

Files placed on repository:
openstack-neutron-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-bigswitch-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-brocade-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-cisco-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-hyperv-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-ibm-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-linuxbridge-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-mellanox-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-metaplugin-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-metering-agent-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-midonet-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-ml2-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-nec-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-nuage-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-ofagent-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-oneconvergence-nvsd-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-opencontrail-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-openvswitch-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-plumgrid-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-ryu-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-vmware-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
openstack-neutron-vpn-agent-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm
python-neutron-2014.2-fuel6.0.mira11.git.9cc27f5.a299407.noarch.rpm

NOTE: Changeset is not merged, created temporary package repository.
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable-1149/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :
Download full text (3.2 KiB)

DEB package neutron has been built for project openstack/neutron
Package version == 2014.2, package release == fuel6.0~mira10+git.9cc27f5.a299407

Changeset: https://review.fuel-infra.org/1149
project: openstack/neutron
branch: openstack-ci/fuel-6.0/2014.2
author: Alexander Ignatov
committer: Alexander Ignatov
subject: Fix context.elevated
status: patchset-created

Files placed on repository:
neutron-common_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-dhcp-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-l3-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-lbaas-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-metadata-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-metering-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-bigswitch-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-bigswitch_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-brocade_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-cisco_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-hyperv_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-ibm-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-ibm_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-linuxbridge-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-linuxbridge_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-metaplugin_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-metering-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-midonet_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-ml2_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-mlnx-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-mlnx_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-nec-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-nec_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-nicira_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-oneconvergence-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-oneconvergence_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-openflow-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-openvswitch-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-openvswitch_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-plumgrid_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-ryu-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-ryu_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-vmware_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-plugin-vpn-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-server_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
neutron-vpn-agent_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb
python-neutron_2014.2-fuel6.0~mira10+git.9cc27f5.a299407_all.deb

NOTE: Changeset is not merged, created temporary package repository....

Read more...

Revision history for this message
OSCI Robot (oscirobot) wrote :

RPM package neutron has been built for project openstack/neutron
Package version == 2014.2, package release == fuel6.0.mira11

Changeset: https://review.fuel-infra.org/1149
project: openstack/neutron
branch: openstack-ci/fuel-6.0/2014.2
author: Alexander Ignatov
committer: Alexander Ignatov
subject: Fix context.elevated
status: change-merged

Files placed on repository:
openstack-neutron-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-bigswitch-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-brocade-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-cisco-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-hyperv-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-ibm-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-linuxbridge-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-mellanox-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-metaplugin-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-metering-agent-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-midonet-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-ml2-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-nec-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-nuage-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-ofagent-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-oneconvergence-nvsd-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-opencontrail-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-openvswitch-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-plumgrid-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-ryu-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-vmware-2014.2-fuel6.0.mira11.noarch.rpm
openstack-neutron-vpn-agent-2014.2-fuel6.0.mira11.noarch.rpm
python-neutron-2014.2-fuel6.0.mira11.noarch.rpm

Changeset merged. Package placed on primary repository
RPM repository URL: http://osci-obs.vm.mirantis.net:82/centos-fuel-6.0-stable/centos

Revision history for this message
OSCI Robot (oscirobot) wrote :

DEB package neutron has been built for project openstack/neutron
Package version == 2014.2, package release == fuel6.0~mira10

Changeset: https://review.fuel-infra.org/1149
project: openstack/neutron
branch: openstack-ci/fuel-6.0/2014.2
author: Alexander Ignatov
committer: Alexander Ignatov
subject: Fix context.elevated
status: change-merged

Files placed on repository:
neutron-common_2014.2-fuel6.0~mira10_all.deb
neutron-dhcp-agent_2014.2-fuel6.0~mira10_all.deb
neutron-l3-agent_2014.2-fuel6.0~mira10_all.deb
neutron-lbaas-agent_2014.2-fuel6.0~mira10_all.deb
neutron-metadata-agent_2014.2-fuel6.0~mira10_all.deb
neutron-metering-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-bigswitch-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-bigswitch_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-brocade_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-cisco_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-hyperv_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-ibm-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-ibm_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-linuxbridge-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-linuxbridge_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-metaplugin_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-metering-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-midonet_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-ml2_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-mlnx-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-mlnx_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-nec-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-nec_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-nicira_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-oneconvergence-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-oneconvergence_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-openflow-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-openvswitch-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-openvswitch_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-plumgrid_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-ryu-agent_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-ryu_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-vmware_2014.2-fuel6.0~mira10_all.deb
neutron-plugin-vpn-agent_2014.2-fuel6.0~mira10_all.deb
neutron-server_2014.2-fuel6.0~mira10_all.deb
neutron-vpn-agent_2014.2-fuel6.0~mira10_all.deb
python-neutron_2014.2-fuel6.0~mira10_all.deb

Changeset merged. Package placed on primary repository
DEB repository URL: http://osci-obs.vm.mirantis.net:82/ubuntu-fuel-6.0-stable/ubuntu

Dmitry Mescheryakov (dmitrymex)
Changed in mos:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.