Clarify vCPUs Usage legend for hypervisors

[Julie Pichon]

The vCPUs usage chart is confusing because it can end up with values like "Used 5 of 4".

(see e.g. https://launchpadlibrarian.net/155236888/Nova_bug_1202965.png which was posted on bug 1202965)

This may be improved in Nova as part of bug 1202965 but I think if it is possible we should try to make the meaning clearer in Horizon. Chatting with a Nova developer and based on the discussion on that other bug as well, the actual meaning is: "This hypervisor has 4 cores and is running VMs with a total of 5 vCPUs." - which is a bit too long for the chart legend itself.

I'd like to suggest adding a star (*) after the small chart legend and putting this full sentence as a legend below the chart series. It may not be the best UI but hopefully it will help with reducing confusion - I'm including the UX tag on this so UX folks can hopefully add their input as well.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/hypervisors/templates/hypervisors/index.html

[Liz Blanchard (lblanchard)]

Is this something that will be fixed when the nova bug is fixed? If not, we might want to think about breaking out vCPUs and Cores into two separate graphs. If they really make sense to be together, we could represent the data a bit clearer to avoid confusion in the future.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/890525
Committed: https://opendev.org/openstack/horizon/commit/ebdb19ab8c84eafaa08930a2d03b6c2970716266
Submitter: "Zuul (22348)"
Branch: master

commit ebdb19ab8c84eafaa08930a2d03b6c2970716266
Author: Radomir Dopieralski <email address hidden>
Date: Fri Aug 4 15:22:08 2023 +0200

    Use Placement API along with the hypervisor stats

    Hypervisor stats do not reflect accurate VCPUs and PCPUs usage, so
    to have a correct picture we need to use Placement API along with
    hypervisors.

    We add VCPUs and PCPUs usage diagrams and Resource Provider tab
    to display correct stats.

    Since there is no python client for the Placement API, and the
    OpenStack SDK doesn't support the endpoints we need, we call the
    endpoints directly.

    Related-Bug: #1974470
    Related-Bug: #1397917

    Change-Id: If41cea0edeec8c95717229eb017e32898417a891

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/horizon/+/905914

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/905915

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/906004
Committed: https://opendev.org/openstack/horizon/commit/3acbf227a41493032c5828945d41d0b193cd960b
Submitter: "Zuul (22348)"
Branch: master

commit 3acbf227a41493032c5828945d41d0b193cd960b
Author: Tatiana Ovchinnikova <email address hidden>
Date: Wed Jan 17 14:52:37 2024 -0600

    Add allocation ratios to Placement stats

    All the Placement API stats "total" show the actual amount of the
    resource that the provider can accommodate. Using allocation ratio
    it is possible to exceed physical constraints.

    This patch uses allocation ratios to display the diagrams properly
    and adds the data to the stats table.

    Closes-Bug: #1974470
    Closes-Bug: #1397917

    Change-Id: Iab0ce21ae63f4cc26d3ec5684615189b8ab35231

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/905915
Committed: https://opendev.org/openstack/horizon/commit/c2b0700d4cff0c54af0b6e34162e6c715ef0820c
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c2b0700d4cff0c54af0b6e34162e6c715ef0820c
Author: Radomir Dopieralski <email address hidden>
Date: Fri Aug 4 15:22:08 2023 +0200

    Use Placement API along with the hypervisor stats

    Hypervisor stats do not reflect accurate VCPUs and PCPUs usage, so
    to have a correct picture we need to use Placement API along with
    hypervisors.

    We add VCPUs and PCPUs usage diagrams and Resource Provider tab
    to display correct stats.

    Since there is no python client for the Placement API, and the
    OpenStack SDK doesn't support the endpoints we need, we call the
    endpoints directly.

    Related-Bug: #1974470
    Related-Bug: #1397917

    Change-Id: If41cea0edeec8c95717229eb017e32898417a891
    (cherry picked from commit ebdb19ab8c84eafaa08930a2d03b6c2970716266)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/905914
Committed: https://opendev.org/openstack/horizon/commit/034630c4d3d0511961aac2461eac32ee29078d2f
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 034630c4d3d0511961aac2461eac32ee29078d2f
Author: Radomir Dopieralski <email address hidden>
Date: Fri Aug 4 15:22:08 2023 +0200

    Use Placement API along with the hypervisor stats

    Hypervisor stats do not reflect accurate VCPUs and PCPUs usage, so
    to have a correct picture we need to use Placement API along with
    hypervisors.

    We add VCPUs and PCPUs usage diagrams and Resource Provider tab
    to display correct stats.

    Since there is no python client for the Placement API, and the
    OpenStack SDK doesn't support the endpoints we need, we call the
    endpoints directly.

    Related-Bug: #1974470
    Related-Bug: #1397917

    Change-Id: If41cea0edeec8c95717229eb017e32898417a891
    (cherry picked from commit ebdb19ab8c84eafaa08930a2d03b6c2970716266)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/horizon/+/907262

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/horizon/+/907263

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/907263
Committed: https://opendev.org/openstack/horizon/commit/a6ee210238066c8056d5fa9ea094d4a05e79f8c9
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit a6ee210238066c8056d5fa9ea094d4a05e79f8c9
Author: Tatiana Ovchinnikova <email address hidden>
Date: Wed Jan 17 14:52:37 2024 -0600

    Add allocation ratios to Placement stats

    All the Placement API stats "total" show the actual amount of the
    resource that the provider can accommodate. Using allocation ratio
    it is possible to exceed physical constraints.

    This patch uses allocation ratios to display the diagrams properly
    and adds the data to the stats table.

    Closes-Bug: #1974470
    Closes-Bug: #1397917

    Change-Id: Iab0ce21ae63f4cc26d3ec5684615189b8ab35231
    (cherry picked from commit 3acbf227a41493032c5828945d41d0b193cd960b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/907262
Committed: https://opendev.org/openstack/horizon/commit/e650127975265bd398c5ccd0f9fc94456a013e0f
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit e650127975265bd398c5ccd0f9fc94456a013e0f
Author: Tatiana Ovchinnikova <email address hidden>
Date: Wed Jan 17 14:52:37 2024 -0600

    Add allocation ratios to Placement stats

    All the Placement API stats "total" show the actual amount of the
    resource that the provider can accommodate. Using allocation ratio
    it is possible to exceed physical constraints.

    This patch uses allocation ratios to display the diagrams properly
    and adds the data to the stats table.

    Closes-Bug: #1974470
    Closes-Bug: #1397917

    Change-Id: Iab0ce21ae63f4cc26d3ec5684615189b8ab35231
    (cherry picked from commit 3acbf227a41493032c5828945d41d0b193cd960b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 24.0.0 release.