cinder service-disable should not change current state of cinder serivces

[Peter Wang]

some service down as below:
stack@ubuntu-server7:~/devstack$ cinder service-list
+------------------+---------------------------------+------+---------+-------+----------------------------+-----------------+
| Binary | Host | Zone | Status | State | Updated_at | Disabled Reason |
+------------------+---------------------------------+------+---------+-------+----------------------------+-----------------+
| cinder-scheduler | ubuntu-server7 | nova | enabled | up | 2014-11-27T22:16:49.000000 | None |
| cinder-volume | ubuntu-server7@pool_backend_1 | nova | enabled | down | 2014-11-27T05:42:35.000000 | None |

you can see, the ubuntu-server7@pool_backend_1 is in down state
then i issued :
stack@ubuntu-server7:~/devstack$ cinder service-disable --reason 'not config anymore' ubuntu-server7@pool_backend_1 cinder-volume

to disable this service

while i checked output of service-list:
stack@ubuntu-server7:~/devstack$ cinder service-list
+------------------+---------------------------------+------+----------+-------+----------------------------+--------------------+
| Binary | Host | Zone | Status | State | Updated_at | Disabled Reason |
+------------------+---------------------------------+------+----------+-------+----------------------------+--------------------+
| cinder-scheduler | ubuntu-server7 | nova | enabled | up | 2014-11-27T22:19:19.000000 | None |
| cinder-volume | ubuntu-server7@pool_backend_1 | nova | disabled | up | 2014-11-27T22:19:17.000000 | not config anymore |

the service was disabled, but the state was set to up, which is not reasonable

Thanks
Peter

[Huang Zhiteng (zhiteng-huang)]

This is unfortunately a side-effect of 'cinder service-disable' touching the service record in DB, which would update the 'updated_at' timestamp of the record, result in the awkward situation you've seen. But that doesn't really hurt much, it's just weird.

[Daniel Snider (daniel-snider)]

A couple minutes after 'cinder service-disable' the state of the cinder service will go back to down on it's own, although this still isn't optimal.

[Rushi Agrawal (rushiagr)]

There is no way to fix this, unless we have another field which keeps track of 'update_at' time for service status entry only, otherwise there is no way to distinguish if the 'updated_at' entry is changed by 'service-disable' command, or due to the periodic updates..

I don't think this falls under low-hanging-fruit tag..

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/154124

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/160104

[OpenStack Infra (hudson-openstack)]

Change abandoned by harsh mishra (<email address hidden>) on branch: master
Review: https://review.openstack.org/154124
Reason: local repository error ,starting a new thread

[harsh mishra (harsh-mishra)]

Waiting for completion of verification and workflow of my fix at:
https://review.openstack.org/160104

[harsh mishra (harsh-mishra)]

need verified,need workflow for this fix to be merged,what are ways to get them?

[harsh mishra (harsh-mishra)]

I have targeted the fix for kilo-rc1 release but the change is not yet committed to Cinder ,is there anything I am missing

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/160104
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ee2a0c890f5f62b4da24a0bae4918f7a1d0ad2d2
Submitter: Jenkins
Branch: master

commit ee2a0c890f5f62b4da24a0bae4918f7a1d0ad2d2
Author: Harsh Mishra <email address hidden>
Date: Sat Feb 28 06:54:43 2015 +0000

    Fix for inconsistent cinder-services state change

    This bug was introduced to cinder as a side effect of fix :
    18365 (https://review.openstack.org/#/c/18365/).
    API “service_update” is used by periodic and manual service-enable/
    disable to update cinder-services table. Due to this ‘updated_at’
    column of cinder-services table receives an update for both periodic
    updates and manual service-enable/disable. Since state of any cinder
    service is calculated based on the ‘updated_at’ column of the service,
    we get inconsistent state transitions if a service is manually
    enabled/disabled and a service-list command is launched before
    “CONF.service_down_time”, for services which are already in a “down”
    state.
    This fix introduces a new column: “modified_at” in cinder-services
    table. As per the fix all the periodic updates will be updated in
    ‘updated_at’ column and manual service-enable/disable in
    “modified_at” column. This will result in correct state transitions
    as ‘updated_at’ column will only contains time value for periodic
    updates which in turn would be used to calculate the state of the
    cinder-service if it is ‘up’/’down’. Also, the time for any service
    receiving an update will be displayed as “updated_at” or
    “modified_at”, which ever is latest.

    Closes-bug: 1397167

    Change-Id: Iaee4a9cec035dd60c9de04699b1135ee306f6257