OSTF fails with error: "AssertionError: Flavor for tests was not created. Seems that something is wrong with nova services."

[Artem Panchenko]

api: '1.0'
astute_sha: dade74af41d4972fe05a1c16ae1db2a2e60c6715
auth_required: true
build_id: 2014-11-26_21-01-00
build_number: '42'
feature_groups:
- mirantis
fuellib_sha: db976a45be4f6606e7c439cbec237fe8482f4f80
fuelmain_sha: 51e66db7750e9c856ba128f35cfb6724895bf479
nailgun_sha: 500e36d08a45dbb389bf2bd97673d9bff48ee84d
ostf_sha: 64cb59c681658a7a55cc2c09d079072a41beb346
production: docker
release: 5.1.1

Sometimes random OSTF test, which creates instance, fails with the following error:

"AssertionError: Flavor for tests was not created. Seems that something is wrong with nova services."

http://jenkins-product.srt.mirantis.net:8080/view/5.1_swarm/job/5.1_fuelmain.system_test.ubuntu.thread_2/59/testReport/(root)/deploy_simple_vlan/deploy_simple_vlan/

Here is the part of OSTF logs:

http://paste.openstack.org/show/139712/

Flavor creation fails because another flavor with the same ID is already exists. This happens because here we use random integer as flavor ID:

https://github.com/stackforge/fuel-ostf/blob/master/fuel_health/nmanager.py#L275

We should check that there is no existing flavor with the same ID before trying to create a new one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146079

[Ryan Moe (rmoe)]

Medium priority bugs are not backported to stable releases.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146079
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=3535878efe441a80eb94089553ba7776d013c24a
Submitter: Jenkins
Branch: master

commit 3535878efe441a80eb94089553ba7776d013c24a
Author: Tatyana Leontovich <email address hidden>
Date: Fri Jan 9 13:26:38 2015 +0200

    Delete nano flavor creation in each test

    * Leave flavor creation only in tests check flavor
    * add method find_micro_flavor to use it,
      when create instance
    * add additional verification for flavor
      id in check_flavor

    Change-Id: I9bedbdcef80ab9d1f07aeac23b88ecabf429a6f8
    Closes-Bug: #1397059

[Tatyanka (tatyana-leontovich)]

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  api: "1.0"
  build_number: "178"
  build_id: "2015-03-09_22-54-44"
  nailgun_sha: "a9a6578a649a2a006c4810b3d0aa6876ac6e8b83"
  python-fuelclient_sha: "4eb787f1ad969bd23c93d192865543dbd45a8626"
  astute_sha: "2d61ee42ec6dae3181d292c7769d32e40d463893"
  fuellib_sha: "62e68af896887ebe18944e6a0a9721e269119ad4"
  ostf_sha: "8df5f2fcdae3bc9ea7d700ffd64db820baf51914"
  fuelmain_sha: "c73b87f7cbc371307a21c368a45a65aa3f4b7a5d"
verified

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/168340

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/168341

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168340
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=9d07ac40f17c57ed5d5e403845d089adfb0fb391
Submitter: Jenkins
Branch: stable/6.0

commit 9d07ac40f17c57ed5d5e403845d089adfb0fb391
Author: Bartłomiej Piotrowski <email address hidden>
Date: Fri Mar 27 14:50:01 2015 +0100

    Correct $osfamily check in Horizon settings template

    It has been incorrectly compared to "redhat", while the fact is "RedHat"
    on affected systems.

    Change-Id: I494348bf9a42ab68a1154d50b0a69c24bddafe60
    Closes-Bug: 1397059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168341
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d18bb247c61c77c7a1cb81f3031039200f4e5201
Submitter: Jenkins
Branch: stable/5.1

commit d18bb247c61c77c7a1cb81f3031039200f4e5201
Author: Bartłomiej Piotrowski <email address hidden>
Date: Fri Mar 27 14:50:01 2015 +0100

    Correct $osfamily check in Horizon settings template

    It has been incorrectly compared to "redhat", while the fact is "RedHat"
    on affected systems.

    Change-Id: I494348bf9a42ab68a1154d50b0a69c24bddafe60
    Closes-Bug: 1397059