Syntax enhancements in some modules

Bug #1397027 reported by Victoria Martinez de la Cruz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
Low
Ricardo Ferreira

Bug Description

Two code syntax enhancements will help to reduce our technical debt

* Parentheses should not be used after certain keywords

Files affected/# of misuses per file

- validation.py/8
- generator.py/7
- memory.py/3
- helpers.py/3
- claims.py/3
- gettextutils.py/2 (this is in common)
- utils.py/2
- version.py/2
- catalogue.py/1
- test_messages.py/1
- test_messages.py/1
- base.py/1
- test_validation.py/1
- utils.py/1
- auth.py/1
- conductor.py/1
- observer.py/1
- backends.py/1
- fileutils.py /1
- utils.py/1
- pools.py/1
- claims.py/1
- log.py/1
- test_validation.py/1

* Collapsible "if" statements should be merged

- base.py/1
- generator.py/1

Changed in zaqar:
assignee: nobody → Doraly Navarro (doralynavarro)
Changed in zaqar:
status: New → Triaged
Changed in zaqar:
assignee: Doraly Navarro (doralynavarro) → nobody
Ricardo Ferreira (rsff)
Changed in zaqar:
assignee: nobody → Ricardo Ferreira (rsff)
Ricardo Ferreira (rsff)
Changed in zaqar:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/163223

Ricardo Ferreira (rsff)
Changed in zaqar:
status: In Progress → Fix Committed
Changed in zaqar:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/163223
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=f2ee58b00c6247302377755a1d9c83b676a09ee5
Submitter: Jenkins
Branch: master

commit f2ee58b00c6247302377755a1d9c83b676a09ee5
Author: Ricardo Ferreira <email address hidden>
Date: Tue Mar 10 23:18:09 2015 +0000

    Syntax enhancements

    Did some syntax improvement by:
    -Removing extraneous parentheses.
    -Collapsing "if" statements.
    -Used set literal notation.
    -Fixed pep8 issue

    Change-Id: I321536058a76bf69af1d6b38d37f81a07a2f7108
    Closes-Bug: #1397027

Changed in zaqar:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in zaqar:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in zaqar:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.