Empty value in PropertyConflict error message

[Sergey Kraynev]

Try to create stack with template:

heat_template_version: 2013-05-23
resources:
  iface:
   type: OS::Neutron::RouterInterface
   properties:
     router_id: e2fd4efe-2ee1-4f7a-ad03-942077c6525b
     subnet: namd
     subnet_id: sdgddg

you will get error message:

ERROR: Cannot define the following properties at the same time: {}.

Conflict properties should be displayed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/137641

[Pavlo Shchelokovskyy (pshchelo)]

JFYI there is this blueprint
https://blueprints.launchpad.net/heat/+spec/mutually-exclusive-properties
and I started an implementation
https://review.openstack.org/#/c/94622/
(long overdue, I know, but I will get back to it soon)

that aims to solve such problems on a more general basis.

[Sergey Kraynev (skraynev)]

Sure, but it looks stopped, So I think the better is have fix now for particular problem, instead of waiting new blueprint.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/137641
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a4ecd1ed33aad0f1ec8296be28fff69e2affcffe
Submitter: Jenkins
Branch: master

commit a4ecd1ed33aad0f1ec8296be28fff69e2affcffe
Author: Sergey Kraynev <email address hidden>
Date: Thu Nov 27 08:20:59 2014 -0500

    Use kwargs for ResourcePropertyConflict exception

    Current approach works correct when error raised in heat-engine,
    but when oslo-messaging try to send this error to heat-api it calls
    this Exception again without any arguments. So it leads to empty output
    in message.
    This patch adds kwargs properties for directly sending parameters to
    parent class and storing them for substitution during re-call in
    oslo-messanging.

    Change-Id: I4e823206c3a88d27241532d9f393c07208af8b73
    Closes-Bug: #1397002

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/140642

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/140642
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=423ee27dcf628be90863da91632489a877619c49
Submitter: Jenkins
Branch: stable/juno

commit 423ee27dcf628be90863da91632489a877619c49
Author: Sergey Kraynev <email address hidden>
Date: Thu Nov 27 08:20:59 2014 -0500

    Use kwargs for ResourcePropertyConflict exception

    Current approach works correct when error raised in heat-engine,
    but when oslo-messaging try to send this error to heat-api it calls
    this Exception again without any arguments. So it leads to empty output
    in message.
    This patch adds kwargs properties for directly sending parameters to
    parent class and storing them for substitution during re-call in
    oslo-messanging.

    Change-Id: I4e823206c3a88d27241532d9f393c07208af8b73
    Closes-Bug: #1397002
    (cherry picked from commit a4ecd1ed33aad0f1ec8296be28fff69e2affcffe)