Delete failed, when OS::Nova::FloatingIPAssociation cannot find server

[Peter Razumovsky]

Follow the next steps:
1. Create template with OS::Nova::FloatingIPAssociation, like http://paste.openstack.org/show/139509/
2. $ heat stack-create test -f test.yaml -P image=test
3. $ heat stack-list
+--------------------------------------+------------+--------------------+----------------------+
| id | stack_name | stack_status | creation_time |
+--------------------------------------+------------+--------------------+----------------------+
| 06a72787-82a6-469d-9eb8-93a35779acd7 | test | CREATE_COMPLETE | 2014-11-27T11:58:35Z |
+--------------------------------------+------------+--------------------+----------------------+
4. $ nova list
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
| 38d6aae1-ee48-4c74-8679-fa0d871380f2 | test-server-it36jmc4vknw | ACTIVE | - | Running | private=10.0.0.39, 172.24.4.39 |
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
5. $ nova delete 38d6aae1-ee48-4c74-8679-fa0d871380f2
Request to delete server 38d6aae1-ee48-4c74-8679-fa0d871380f2 has been accepted.
6. $ nova list
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
| ID | Name | Status | Task State | Power State | Networks |
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
+--------------------------------------+-------------------------+--------+------------+-------------+--------------------------------+
7. $ heat stack-delete test
+--------------------------------------+------------+--------------------+----------------------+
| id | stack_name | stack_status | creation_time |
+--------------------------------------+------------+--------------------+----------------------+
| 06a72787-82a6-469d-9eb8-93a35779acd7 | test | DELETE_IN_PROGRESS | 2014-11-27T11:58:35Z |
+--------------------------------------+------------+--------------------+----------------------+
8. $ heat event-list test
+---------------+--------------------------------------+------------------------------------------+--------------------+----------------------+
| resource_name | id | resource_status_reason | resource_status | event_time |
+---------------+--------------------------------------+------------------------------------------+--------------------+----------------------+
| flipas | f7f5346a-836c-47e9-a8b3-edfcaeb8a70c | AssertionError: Must specify client name | DELETE_FAILED | 2014-11-27T11:59:13Z |
| flipas | 85685439-8f8f-4b64-b18e-eb0832042f3e | state changed | DELETE_IN_PROGRESS | 2014-11-27T11:59:13Z |
| flipas | 3cd10377-2b74-429f-b11a-f60dec699667 | state changed | CREATE_COMPLETE | 2014-11-27T11:58:49Z |
| flipas | 583dceb0-4ad0-4e17-bd61-d8faece7b962 | state changed | CREATE_IN_PROGRESS | 2014-11-27T11:58:46Z |
| server | 232f4f02-446d-44bb-93cc-7d7924d41b12 | state changed | CREATE_COMPLETE | 2014-11-27T11:58:46Z |
| flip | b50dc194-e56d-4947-9c3b-7402d37dfa67 | state changed | CREATE_COMPLETE | 2014-11-27T11:58:38Z |
| flip | 8945cefd-cbc0-4e95-9de7-624e4abc022e | state changed | CREATE_IN_PROGRESS | 2014-11-27T11:58:37Z |
| server | b0e2ab0a-c443-47d9-9c5c-43ddefe24ffd | state changed | CREATE_IN_PROGRESS | 2014-11-27T11:58:36Z |
+---------------+--------------------------------------+------------------------------------------+--------------------+----------------------+

And stack is enclosed in this state DELETE FAILED. It is wrong.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/137624

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/137624
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=898f94347dc011aba7f2cb03b1ff5d384691aeda
Submitter: Jenkins
Branch: master

commit 898f94347dc011aba7f2cb03b1ff5d384691aeda
Author: Peter Razumovsky <email address hidden>
Date: Thu Nov 27 15:16:04 2014 +0300

    Add default_client_name in Nova::FloatingIPAssoc

    default_client_name has been missed, so stack fails
    to delete, if server, from which floating ip association
    depends, not exist.

    Change-Id: I01bb91f8afaeb483e1a4bb55653dc3189a62bf12
    Closes-bug: #1396982

[Sean McCully (sean-mccully)]

This appears to affect Juno release, is there a reason this isn't fixed in Juno?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/189574

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/189574
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d011ce8de83b51abc1c4ffdbe147f8c317cf6ac5
Submitter: Jenkins
Branch: stable/juno

commit d011ce8de83b51abc1c4ffdbe147f8c317cf6ac5
Author: Peter Razumovsky <email address hidden>
Date: Thu Nov 27 15:16:04 2014 +0300

    Add default_client_name in Nova::FloatingIPAssoc

    default_client_name has been missed, so stack fails
    to delete, if server, from which floating ip association
    depends, not exist.

    Change-Id: I01bb91f8afaeb483e1a4bb55653dc3189a62bf12
    Closes-bug: #1396982
    (cherry picked from commit 898f94347dc011aba7f2cb03b1ff5d384691aeda)