Selenium gate job failing with timeout (horizon.test.jasmine.jasmine_tests.ServicesTests)

Bug #1396954 reported by Julie Pichon
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Critical
Julie Pichon
Juno
Fix Released
Critical
Julie Pichon

Bug Description

A great number of the selenium unit tests jobs seem to currently be failing due to a timeout on horizon.test.jasmine.jasmine_tests.ServicesTests:

014-11-27 10:04:38.098 | ======================================================================
2014-11-27 10:04:38.098 | ERROR: test (horizon.test.jasmine.jasmine_tests.ServicesTests)
2014-11-27 10:04:38.099 | ----------------------------------------------------------------------
2014-11-27 10:04:38.099 | Traceback (most recent call last):
2014-11-27 10:04:38.099 | File "/home/jenkins/workspace/gate-horizon-selenium/horizon/test/helpers.py", line 287, in test
2014-11-27 10:04:38.099 | self.run_jasmine()
2014-11-27 10:04:38.099 | File "/home/jenkins/workspace/gate-horizon-selenium/horizon/test/helpers.py", line 271, in run_jasmine
2014-11-27 10:04:38.099 | wait.until(jasmine_done)
2014-11-27 10:04:38.099 | File "/home/jenkins/workspace/gate-horizon-selenium/.tox/venv/local/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", line 71, in until
2014-11-27 10:04:38.100 | raise TimeoutException(message)
2014-11-27 10:04:38.100 | TimeoutException: Message:

This is blocking the Horizon gate.

See for example:
http://logs.openstack.org/20/137420/1/check/gate-horizon-selenium/0707449/console.html
http://logs.openstack.org/37/122737/15/check/gate-horizon-selenium/9f83318/console.html
http://logs.openstack.org/30/135730/2/check/gate-horizon-selenium/35564c7/console.html

Tags: unittest
Revision history for this message
Julie Pichon (jpichon) wrote :

Running ./run_tests.sh --only-selenium locally, sometimes the page at http://localhost:8081/jasmine/ServicesTests doesn't seem to load at all and remains blank, so it's unlikely simply increasing the timeout would help.

Revision history for this message
Julie Pichon (jpichon) wrote :

This is likely due to a Jasmine package update, XStatic-Jasmine on Pypi was updated to 2.1. 2.0 yesterday (from 1.3 something). Talking with MaxV in theory the current tests should work with both 1.3 and 2.x but it doesn't seem to be the case. We're not currently capping so we are using the new version.

MaxV has a patch up that should resolve issues related to Jasmine 2.x: https://review.openstack.org/#/c/137598/ however it has a number of dependencies and is waiting on a global requirements updated.

I see 2 potential solutions: add a cap to the global requirements, or disable the test currently and have MaxV update his patch to reenable it (in the patch "upgrading" Horizon to use Jasmine 2.x). Since a lot of the work is already underway for using Jasmine 2.x, I'm somewhat in favour of #2 to avoid back and forth with the global requirements repo and to make sure we have the solution is in place when the test is reenabled.

Julie Pichon (jpichon)
Changed in horizon:
assignee: nobody → Julie Pichon (jpichon)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137614

Changed in horizon:
status: New → In Progress
Revision history for this message
Julie Pichon (jpichon) wrote :

If the upgrade to 2.x takes longer to get in than anticipated, we can also propose the requirements cap then revert that patch ahead of the upgrade so we don't leave the tests disabled for too long.

Revision history for this message
Julie Pichon (jpichon) wrote :

This is affecting stable/juno as well. I will propose a global requirements cap for that one, since we won't be backporting the feature work on Jasmine 2.x.

Revision history for this message
Julie Pichon (jpichon) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/137614
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d1c098550d0b4b631291ab93f022bd4d26ea8938
Submitter: Jenkins
Branch: master

commit d1c098550d0b4b631291ab93f022bd4d26ea8938
Author: Julie Pichon <email address hidden>
Date: Thu Nov 27 11:31:55 2014 +0000

    Temporarily disable the Jasmine unit tests

    A recent Jasmine package upgrade to move to Jasmine 2.x is breaking the
    Horizon gate. There is other work underway to make Horizon more
    compatible with Jasmine 2.x (see comment #2 in the bug for more
    details), let's disable the tests for now and reenable them shortly as
    part of that other work when we can make sure the upgrade to 2.x
    happens when the test codebase is ready to handle it.

    Change-Id: I745e8957128772a7415a20393940068dbd89a493
    Closes-Bug: #1396954

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
Julie Pichon (jpichon) wrote :

Juno update:

The global requirements update patch has merged. https://review.openstack.org/#/c/137648/
The requirement proposal update at https://review.openstack.org/#/c/137575/2 now needs to be merged in order to unblock the gate.

Revision history for this message
Julie Pichon (jpichon) wrote :
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.