set stack to ADOPT_FAILED if disable stack adopt

Bug #1396917 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

If disable stack adopt, stack will always in CREATE_IN_PROGRESS state after adopt a stack.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137570

Changed in heat:
status: New → In Progress
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Medium
milestone: none → kilo-1
Revision history for this message
Unmesh Gurjar (unmesh-gurjar) wrote :

IMO, if stack adopt is disabled, in the first place the new stack should not be stored (in db)!

Changed in heat:
assignee: huangtianhua (huangtianhua) → Angus Salkeld (asalkeld)
Angus Salkeld (asalkeld)
Changed in heat:
milestone: kilo-1 → kilo-2
Revision history for this message
Thierry Carrez (ttx) wrote :

In the pipe now, let's try to sneak it into k1

Changed in heat:
milestone: kilo-2 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/137570
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0217812261482d238150e8dea4fc8fa56eb332a4
Submitter: Jenkins
Branch: master

commit 0217812261482d238150e8dea4fc8fa56eb332a4
Author: Angus Salkeld <email address hidden>
Date: Thu Dec 18 12:09:11 2014 +1000

    Check stack adopt enable before adopting

    If the configuration is disabled, don't start to adopt.

    Co-Authored-by: huangtianhua <email address hidden>
    Co-Authored-by: asalkeld <email address hidden>

    Change-Id: Iddb5024971f9f7882c5e46d879439182d2a92124
    Closes-Bug: #1396917

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.