Dashboard#get_panel_group throws KeyError

[Michael Hagedorn]

In horizon/base.py, calling Dashboard#get_panel_group and passing in a non existent panel, the code blows up with a KeyError. It would make more semantic sense for it to return None.

[Michael Hagedorn (mike-hagedorn)]

this is the same kind of thing as 1386826

[Michael Hagedorn (mike-hagedorn)]

Ok lets try this again: Is very similar to Bug #1386826

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/137413
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=754585d67be0673609fac93683f495d8f02aea7c
Submitter: Jenkins
Branch: master

commit 754585d67be0673609fac93683f495d8f02aea7c
Author: Mike Hagedorn <email address hidden>
Date: Wed Nov 26 12:16:22 2014 -0500

    KeyError on getting PanelGroup

    When trying to get a PanelGroup at runtime and
    you specify a nonregistered panel, a KeyError is
    thrown when calling Dashboard.get_panel_group.
    Retrieving values from a Dict using the [] formulation
    results in a KeyError for non existent keys. Using
    Dict#get returns None for non existent keys which is
    what this change does.

    This is relevant to the dynamic panel efforts going on.

    Closes-Bug: 1396682
    Change-Id: I532c3be04fdd229dfd8e01b68320b2eecb6fd866