Post-Creation option marked mandatory in Launch Instance window

Bug #1396501 reported by Yamini Sardana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Masco
Juno
Fix Released
Low
Kieran Spear

Bug Description

In Project -> Instances -> Launch Instance window, the Post-Creation tab is marked with a * making it a mandatory parameter whereas it is not a mandatory parameter.

It represents --user-data, which is an optional argument. Also, if we do not specify anything in the Script Data (when Direct Input is the script source) or if we do not choose a file (when File is the script source), and launch an instance, no error is raised.

Thus, the Asterisk sign is mis-leading and should be removed to make it an optional parameter.

Changed in horizon:
assignee: nobody → Kanchan Gupta (kanchan-gupta1)
Changed in horizon:
assignee: Kanchan Gupta (kanchan-gupta1) → tcs_openstack_group (tcs-openstack-group)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138290

Changed in horizon:
assignee: tcs_openstack_group (tcs-openstack-group) → Masco Kaliyamoorthy (masco)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/138290
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db33f9f944eed44171bbe744c88d8985275af26b
Submitter: Jenkins
Branch: master

commit db33f9f944eed44171bbe744c88d8985275af26b
Author: Masco Kaliyamoorthy <email address hidden>
Date: Tue Dec 2 14:59:17 2014 +0530

    removing mandatory mark for post_creation tab

    In launch instance form the post creation tab
    having the * symbol, which means the the script
    data is mandatory. but this is optional field.

    so removing the the * symbol from the
    post-creation tab.

    Change-Id: If71cdd793723a2777356da773ae12deb68eb55e2
    Closes-Bug: #1396501

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/149509

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/juno)

Reviewed: https://review.openstack.org/149509
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=070771ba3579c8a6bf5b424394fede89c17abcad
Submitter: Jenkins
Branch: stable/juno

commit 070771ba3579c8a6bf5b424394fede89c17abcad
Author: Masco Kaliyamoorthy <email address hidden>
Date: Tue Dec 2 14:59:17 2014 +0530

    removing mandatory mark for post_creation tab

    In launch instance form the post creation tab
    having the * symbol, which means the the script
    data is mandatory. but this is optional field.

    so removing the the * symbol from the
    post-creation tab.

    (cherry picked from commit db33f9f944eed44171bbe744c88d8985275af26b)

    Conflicts:
     openstack_dashboard/dashboards/project/instances/workflows/create_instance.py

    Closes-Bug: #1396501
    Change-Id: If71cdd793723a2777356da773ae12deb68eb55e2

Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.