OVSInterfaceDriver should use ovs_lib not call ovs-vsctl directly

Bug #1396489 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Cedric Brandily

Bug Description

ovs_lib module is responsible for the interaction with OVS but OVSInterfaceDriver._ovs_add_port() method calls directly
ovs-vsctl which implies inconsistencies: ovs_lib calls ovs-vsctl with a timeout but not OVSInterfaceDriver._ovs_add_port().

Tags: ovs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137303

Changed in neutron:
assignee: nobody → Cedric Brandily (cbrandily)
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → kilo-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/137303
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7c3921585e404c31272c4d31ed326f7323c062d8
Submitter: Jenkins
Branch: master

commit 7c3921585e404c31272c4d31ed326f7323c062d8
Author: Cedric Brandily <email address hidden>
Date: Wed Nov 26 00:31:22 2014 +0000

    Remove ovs-vsctl call from OVSInterfaceDriver

    ovs_lib module is responsible for the interaction with OVS but
    OVSInterfaceDriver._ovs_add_port() method calls directly
    ovs-vsctl which implies inconsistencies: ovs_lib calls ovs-vsctl
    with a timeout but not OVSInterfaceDriver._ovs_add_port().

    This change moves ovs-vsctl call in OVSInterfaceDriver._ovs_add_port
    to ovs_lib.

    Closes-Bug: #1396489
    Change-Id: I4d03f8beef2c5f2366ad2d1cf5f0b18b4f2857cd

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.