Group Management button just says "Add..."

[Cindy Lu]

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/groups/tables.py#L175

Change to "Add Users"

* Need have Identity v3 support enabled in local_settings.py to get this panel.

[Lin Hua Cheng (lin-hua-cheng)]

This is by design, I actually borrowed the idea from the Add user function in AD.

[Lin Hua Cheng (lin-hua-cheng)]

The button does not Add the user yet, it just opens a pop-up to allow admin to add users to group. Perhaps the UX team have some suggestions?

[Cindy Lu (clu-m)]

I see, then I guess it isn't a bug. Just though it looked funny.

[Liz Blanchard (lblanchard)]

Lin - I see where you are coming from by using the idea you saw in AD. I think the main issue here is that it feels inconsistent with the button treatments through out the rest of Horizon. I think it should still be called "Add User" even though the user isn't added right then and there by clicking the button. It will still let the end-user know that the point of clicking this button is to add a user.

Hopefully this makes sense, but I'm happy to chat further about it if you'd like!

Best,
Liz

[Marcos Lobo (marcos-fermin-lobo)]

I suggest to change it by "Add user..." or "Add member..."

[Shamail Tahir (shamail-tahir)]

Hi, if we agree that this change will improve the UX then can I please make the change as my first OpenStack contribution? It will help me since it's a simple change and I can learn the process.

[Lin Hua Cheng (lin-hua-cheng)]

Liz - Thanks for looking, I am open to changing the button name if it does improve the consistency. Was just giving the context why it was just called "Add...". If folks thinks the changing the name is better, let's do that! :)

Shamail: Thanks for your interest in contributing, I've assigned your first bug! Feel free to reach out to folks in #openstack-horizon in IRC if you get blocked. Good luck

[Shamail Tahir (shamail-tahir)]

@Lin: Thank you! I will certainly reach out via IRC if I encounter any issues. I will be changing it "Add Members" to stay in line with the class name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/146383

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/146383
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e676c8dc72fcd44d7e8a56d3db59f7319e74d9e8
Submitter: Jenkins
Branch: master

commit e676c8dc72fcd44d7e8a56d3db59f7319e74d9e8
Author: Shamail Tahir <email address hidden>
Date: Sun Jan 11 22:18:08 2015 -0800

    Change "Add..." to "Add Users" in Group Management

    The button being changed can be found under Horizon -> Identity
    -> Groups -> Manage Members (when Identity API v3 is enabled
    in local_settings.py). The change was requested for UX enhancement.
    Closes-Bug: 1396326

    Change-Id: I544d1b28b2397731f7e2e9058388edc0c45cd15a