Migration scripts 037, 041, and 043 treat raw_template.template as if it were a dict, but it's actually a string. In those scripts, raw_template is a RowProxy object, not a RawTemplate object (where raw_template.template would, in fact, be a dict). Furthermore, a RowProxy object does not allow attributes to be set, yet that's exactly what those migration scripts do.
The bug will manifest itself with the following test in test_migrations.py:
def _pre_upgrade_049(self, engine):
raw_template = utils.get_table(engine, 'raw_template')
templ = '''{"HeatTemplateFormatVersion" : "2012-12-12",
"Parameters" : {
"foo" : { "Type" : "String", "NoEcho": "True" },
"bar" : { "Type" : "String", "NoEcho": "True", "Default": "abc" },
"blarg" : { "Type" : "String", "Default": "quux" }
}
}'''
temp = [dict(id=4, template=templ, files='{}')]
engine.execute(raw_template.insert(), temp)
user_creds = utils.get_table(engine, 'user_creds')
user = [dict(id=5, username='testuser', password='notthis',
tenant='mine', auth_url='bla',
tenant_id=str(uuid.uuid4()),
trust_id='',
trustor_user_id='')]
engine.execute(user_creds.insert(), user)
event = utils.get_table(engine, 'event')
engine.execute(event.delete())
stack = utils.get_table(engine, 'stack')
engine.execute(stack.delete())
stack_ids = ['967aaefb-152e-405d-b13a-35d4c816390a',
'9e9deba9-a303-4f29-84d3-c8165647c47b',
'9a4bd1ec-8b21-46cd-964a-f66cb1cfa2fd']
parameters = '{"parameters": {"foo": "test"}}'
data = [dict(id=ll_id, name='fruity',
raw_template_id=temp[0]['id'],
user_creds_id=user[0]['id'],
username='testuser', disable_rollback=True,
parameters=parameters)
for ll_id in stack_ids]
engine.execute(stack.insert(), data)
return data
Fix proposed to branch: master
Review: https:/