Logging the deprecation of an API endpoint is not useful

[aeva black]

Patch f04d7513 added a new API endpoint for changing node maintenance mode, while introducing the ability to store a maintenance reason.

This patch also added a WARNING to the log file, when a client uses the existing PATCH mechanism to change the maintenance field.

When issuing "ironic node-update UUID replace maintenance=True", the following entry in ironic-api log file is recorded.

2014-11-24 12:27:46.384 17301 WARNING ironic.api.controllers.v1.node [-] Setting maintenance via node update is deprecated. The /v1/nodes/<uuid>/maintenance endpoint should be used instead.

Such an error is not helpful to Operators, who do not have control over what HTTP requests are issued.

The PATCH mechanism was not actually deprecated or removed, and no warning is, in any way, given to users who are using PATCH to change this field today.

I suggest we remove this logging line.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136934

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136934
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=13768f1f572b7c4ba4917948f67cbca3f62a2aac
Submitter: Jenkins
Branch: master

commit 13768f1f572b7c4ba4917948f67cbca3f62a2aac
Author: Jim Rollenhagen <email address hidden>
Date: Mon Nov 24 16:31:23 2014 -0800

    Remove useless deprecation warning for node-update maintenance

    This isn't useful to the people actually making the request, so
    let's remove it.

    Change-Id: I4498e7ce5153822c61f6aa41bca1aba87be84a03
    Closes-Bug: 1395946