Hyper-V Inspector's disk metrics cannot be cached

Bug #1395807 reported by Claudiu Belu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
Claudiu Belu
Juno
Fix Released
Medium
Claudiu Belu

Bug Description

Hyper-V Inspector yields a virt_inspector.Disk(device=device), where device is a dictonary. Ceilometer compute agent will then try to cache the Inspector's metrics into a dictionary, which results in an exception:

18:45:12.516 1188 INFO ceilometer.agent [-] Polling pollster disk.device.read.requests.rate in the context of meter_source
2014-11-23 18:45:12.532 1188 INFO ceilometer.agent [-] Polling pollster disk.read.requests in the context of meter_source
2014-11-23 18:45:13.173 1188 ERROR ceilometer.compute.pollsters.disk [-] Ignoring instance instance-00000016: unhashable type: 'dict'
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk Traceback (most recent call last):
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk File "C:\Program Files (x86)\Cloudbase Solutions\OpenStack\Nova\Python27\lib\site-packages\ceilometer\compute\pollsters\disk.py", line 116, in get_samples
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk instance_name,
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk File "C:\Program Files (x86)\Cloudbase Solutions\OpenStack\Nova\Python27\lib\site-packages\ceilometer\compute\pollsters\disk.py", line 85, in _populate_cache
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk per_device_read_bytes[disk.device] = info.read_bytes
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk TypeError: unhashable type: 'dict'
2014-11-23 18:45:13.173 1188 TRACE ceilometer.compute.pollsters.disk
2014-11-23 18:45:13.798 1188 ERROR ceilometer.compute.pollsters.disk [-] Ignoring instance instance-00000010: unhashable type: 'dict'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136849

Changed in ceilometer:
assignee: nobody → Claudiu Belu (cbelu)
status: New → In Progress
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → kilo-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/136849
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=a2e11a37aca6d4c0f76376938a147a37b1950ec6
Submitter: Jenkins
Branch: master

commit a2e11a37aca6d4c0f76376938a147a37b1950ec6
Author: Claudiu Belu <email address hidden>
Date: Mon Nov 24 19:57:51 2014 +0200

    Fixes Hyper-V Inspector disk metrics cache issue

    Hyper-V Inspector yields a Disk with the property
    'device' containing a dictionary. This causes an
    exception when the values are cached in a dictionary
    using the said 'device' as a key.

    Closes-Bug: #1395807

    Change-Id: I09b4ec2a37a6f7e6580a059517ab6e606bfc346f

Changed in ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/137103

Claudiu Belu (cbelu)
tags: added: hyper-v juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (stable/juno)

Reviewed: https://review.openstack.org/137103
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=1324ab751b8d350f9460006581d84f5beda86285
Submitter: Jenkins
Branch: stable/juno

commit 1324ab751b8d350f9460006581d84f5beda86285
Author: Claudiu Belu <email address hidden>
Date: Mon Nov 24 19:57:51 2014 +0200

    Fixes Hyper-V Inspector disk metrics cache issue

    Hyper-V Inspector yields a Disk with the property
    'device' containing a dictionary. This causes an
    exception when the values are cached in a dictionary
    using the said 'device' as a key.

    Closes-Bug: #1395807

    Change-Id: I09b4ec2a37a6f7e6580a059517ab6e606bfc346f
    (cherry picked from commit a2e11a37aca6d4c0f76376938a147a37b1950ec6)

tags: added: in-stable-juno
Eoghan Glynn (eglynn)
tags: removed: juno-backport-potential
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.