Engine race condition between on_task_result and start_workflow/on_task_result

Bug #1395679 reported by Renat Akhmerov
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Critical
Renat Akhmerov

Bug Description

If action completes fast enough then corresponding on_task_result() gets called before the first transaction in start_workflow() completes hence task DB instance may not exist yet.

The same can happen between two calls on_task_result().

Changed in mistral:
importance: Undecided → Critical
assignee: nobody → Renat Akhmerov (rakhmerov)
milestone: none → kilo-1
Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/137313

Changed in mistral:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/137313
Committed: https://git.openstack.org/cgit/stackforge/mistral/commit/?id=9da521b841430ba10f22c03386273e562a21d13a
Submitter: Jenkins
Branch: master

commit 9da521b841430ba10f22c03386273e562a21d13a
Author: Renat Akhmerov <email address hidden>
Date: Wed Nov 26 15:43:41 2014 +0600

    Redesigning engine to move all remote calls from transactions

    * Fixes engine race condition between start_workflow and on_task_result methods
    * Engine commands now have local and remote parts (in fact, "in tx" and "non tx")

    Closes-Bug: #1395679
    Change-Id: Icd4aa1a546893b815c01bea23880cde139df2d1b

Changed in mistral:
status: Fix Committed → Fix Released
Changed in mistral:
milestone: kilo-1 → 2015.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.