remove puppet run from containers which don't need configuration

[Matthew Mosesohn]

rsync and rsyslog containers do not need any information about passwords or other configuration on the Fuel Master, so they can become totally stateless and stop running puppet apply on startup.

Marking as high priority because its fix is related to https://bugs.launchpad.net/fuel/+bug/1382531

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136725

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/136731

[Bogdan Dobrelya (bogdando)]

Sounds reasonable. If puppet changes nothing due to the container's statically built nature, do not apply it at all.

[Dmitry Borodaenko (angdraug)]

Why is there a commit targeted for stable/5.1 but bug is only targeted for 6.0?

[Dmitry Borodaenko (angdraug)]

Also explanation of why this bug is High priority ("because it is related to bug #1382531") is insufficient. There's no explanation neither here nor in bug #1382531 why these two bugs are related.

[Matthew Mosesohn (raytrac3r)]

This bug should be applied to both 6.0 and 5.1.1 for a number of reasons.

Dmitry, these bugs are related because running puppet with host manifests mounted interferes with upgrades. Here's the situation:
1 - in 5.1 /etc/puppet/modules is 5.1 manifests
2 - upgrade host to 5.1.1 and /etc/puppet/modules is still 5.1 manifests (5.1.1 goes to a new directory)
3 - restart new 5.1.1 rsync container and puppet applies
4 - 5.1.1 rsync container ends up applying 5.1 manifests and breaks things because it's essentially downgrading itself

The initial solution I wanted was just so get the fuel_upgrade utility to just update the symlink, but that was categorically rejected as the wrong solution. The next approach I took was to mount host puppet manifests inside rsync container under /puppet, but that was broken in 6.0 (but not 5.1.1) because of https://review.openstack.org/#/c/136393/ . I still got pushback on this patch too, even though most agree with it and it will eventually be merged. The next approach was https://bugs.launchpad.net/fuel/+bug/1395047 which also would have solved this. It was met initially with resistance as well, but should now be accepted.

I sent an email detailing this to you Dmitry regarding our situation earlier on Monday.

[Matthew Mosesohn (raytrac3r)]

The bug is tested and confirmed on a custom iso deployment run by internal jenkins so it is 100% ready to merge, but Vladimir Kuklin blocked it with Gerrit votes.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136725
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=e3c385db9f5ae3b73117dc47238659a4d3bfac0b
Submitter: Jenkins
Branch: master

commit e3c385db9f5ae3b73117dc47238659a4d3bfac0b
Author: Matthew Mosesohn <email address hidden>
Date: Mon Nov 24 12:58:28 2014 +0400

    Remove puppet run from static containers

    Additional puppet runs have no impact on deployment
    of rsync and rsyslog containers because they do not
    change their configuration based on how a user deploys
    their environment.

    Change-Id: Ic5aac99620a8b6e24c5c5c2be9d246186df08a6c
    Closes-Bug: #1395658
    Related-Bug: #1382531

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136731
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=ace6f48b84a2bf60898de7188688e2ee0acf259e
Submitter: Jenkins
Branch: stable/5.1

commit ace6f48b84a2bf60898de7188688e2ee0acf259e
Author: Matthew Mosesohn <email address hidden>
Date: Mon Nov 24 12:58:28 2014 +0400

    Remove puppet run from static containers

    Additional puppet runs have no impact on deployment
    of rsync and rsyslog containers because they do not
    change their configuration based on how a user deploys
    their environment.

    Change-Id: Ic5aac99620a8b6e24c5c5c2be9d246186df08a6c
    Closes-Bug: #1395658
    Related-Bug: #1382531

[Andrey Sledzinskiy (asledzinskiy)]

verified on {

    "build_id": "2014-12-26_14-25-46",
    "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4",
    "build_number": "58",
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90",
    "production": "docker",
    "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8",
    "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91",
    "feature_groups": [
        "mirantis"
    ],
    "release": "6.0",
    "release_versions": {
        "2014.2-6.0": {
            "VERSION": {
                "build_id": "2014-12-26_14-25-46",
                "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4",
                "build_number": "58",
                "api": "1.0",
                "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90",
                "production": "docker",
                "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8",
                "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "6.0",
                "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"
            }
        }
    },
    "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"

}