Find standard for EQ parameter display order

Bug #1395285 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Opinion
High
RJ Skerry-Ryan

Bug Description

With latest master, we use the new <EffectRack2_EffectUnit$_button_parameter$> to control the low/mid/high eq knobs.

With the Deere skin, this leads to the LOW/MID/HIGH order (from top to bottom) , while other skins have the HIGH/MID/LOW order. The later one can be found on nearly all mixers, hardware and software alike.

Before just reversing the eq order in the Deere mixer section, i ask to set for a standard. Also because It affects all effects loaded into a EQ rack, and the order of parameters there will be different as if you load the same effect in a regular <EffectRack1>

Tags: eq polish
Revision history for this message
Daniel Schürmann (daschuer) wrote :

It is intended to put the parameter 1 to the bottom, so we follow the standard for all available EQs:
High (3)
Mid (2)
Low (1)

and for the filters on the EQ knobs:
HpF
Resonance
LpF

We have decided to limit the parameter count of an effect in the EffectChains to 8. It is an open discussion what to do in the EQ Rack.

When we started to implement this feature, we wanted to limit the pure parameters to three + three kill buttons + a morphic knob and button pair, that can be either a filter (quick effect button) or a fourth EQ button.

In the LV2 branch we have th option to hide manifest parameters from the parameter control objects.
I am planning to use this feature for an upcoming four band EQ and bind the hidden manifest parameter 1 to the EQ Chain parameter (super button). The manifest parameter 2 becomes the CO parameter 1 in this case.

Since the four band EQ is a rare use case, we may follow the Controllers solution on the skin as well and use always this Layout
High
Mid
Low
Filter/Sub
(My favorite)

Or we may simply add a new knob for the four band use case
High
Mid
Low
Sub
Filter
And use the morphic Filter/Sub knob on controllers only.

It was also discussed to use the Gain button for the four knobs EQ use case

IMHO it is finally up to the skin designer. But we will not have more than four parameters and button in any case.

Revision history for this message
Owen Williams (ywwg) wrote :

Daniel that's not the ordering we decided on in the long eq PR. We are going to edit the filter effects so that High EQ is parameter 1 and Low EQ is parameter 3. That way if controller designers want to use the filter knob as a 4th eq knob, they can just remap that one knob and be done.

As RJ has said, eventually there will need to be some per-effect user configurability in the future because different users will want different knobs to control different parameters. For now we will hard-code the parameter orders so they work easily.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → High
status: New → Confirmed
milestone: none → 1.12.0
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Sorry Guys, we have not a commmon committment to reordering of the EQ parameters.

It is a stong reason, that in all extern EQ Plugins we have a base to terible order.
And reodering will probably solve the filter knob mapping for a sertant type of controllers, but will introduce other problems elsewhere.

It is a no issue if we use a 3 band EQ only.
And for the 4 Band type we have two solutions on the controller
1 using the gain knob. -> here the current order fits
2 using the filter knob -> here we we have the parameter disable feature from the LV2 branch + A hidden super knob mapping we have to add while we add the 4 band EQ

Revision history for this message
Michael S. (arbeit-u) wrote :

As user my statement:
For a user it isn't intresting what's going on in backround or is discussed everywhere. It's normal that high is top/up. That's the point.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks for the input Michael! However I think you may be confused -- we aren't proposing low (top) to high (bottom) -- that's a side effect of the internal layout discussion we are having. The release skins will be low (left) to high (right) and high(top) to low(bottom) as usual.

I think you may have been confused by Deere's current Low top High down positioning.

The UI will certainly be left to right

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Er, ignore those last two sentences -- they were a draft response. :)

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

As for the discussion -- if we order our native plugin effects high to low then they will show up in full effect racks as high to low in left to right order which would be confusing. So this isn't a very good solution after all. Let's keep the internal low to high order.

So for controller presets without an auto-switcher for the filter button -- users will have to point-and-click map 4 buttons instead of 1. For controller presets with an auto-switcher it will be automatic if the preset author desires to make a pregain or a filter knob automatically swap places with the 4th EQ band.

But that will always be a choice left up to the controller preset author or user.

Changed in mixxx:
assignee: nobody → RJ Ryan (rryan)
status: Confirmed → Fix Committed
status: Fix Committed → Opinion
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

For lack of a "decided" option -- I picked Opinion.

Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7671

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.