Circuit conversion to STG creates additional signals for outputs
Bug #1395102 reported by
Danil Sokolov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Workcraft |
Fix Committed
|
Medium
|
Danil Sokolov |
Bug Description
Circuit conversion to STG creates separate signals for the driver gate and for the primary output itself. Instead only a signal for the gate output should be created, but named more cleverly:
- If a gate is connected to a single primary output, then the signal associated to the gate output contact should take the name of the output port and its type should be OUTPUT.
- Otherwise, if a gate does not drive an output port, then the signal name should be the name of the gate itself and the type INTERNAL.
- Otherwise, if a gate has several output contacts, then they should be named <gate_name>
Related branches
lp:~danilovesky/workcraft/trunk-bug-1395102
- Danil Sokolov: Approve
-
Diff: 779 lines (+282/-125)17 files modifiedCircuitPlugin/src/org/workcraft/plugins/circuit/CircuitComponent.java (+10/-0)
CircuitPlugin/src/org/workcraft/plugins/circuit/Contact.java (+20/-0)
CircuitPlugin/src/org/workcraft/plugins/circuit/Environment.java (+10/-0)
CircuitPlugin/src/org/workcraft/plugins/circuit/VisualCircuit.java (+24/-1)
CircuitPlugin/src/org/workcraft/plugins/circuit/VisualContact.java (+18/-10)
CircuitPlugin/src/org/workcraft/plugins/circuit/tasks/CheckCircuitTask.java (+8/-4)
CircuitPlugin/src/org/workcraft/plugins/circuit/tools/STGGenerator.java (+135/-58)
WorkcraftCore/src/org/workcraft/Framework.java (+3/-2)
WorkcraftCore/src/org/workcraft/Info.java (+2/-2)
WorkcraftCore/src/org/workcraft/dom/DefaultMathNodeRemover.java (+35/-34)
WorkcraftCore/src/org/workcraft/gui/MainWindow.java (+8/-8)
WorkcraftCore/src/org/workcraft/gui/propertyeditor/FileCellEditor.java (+1/-1)
WorkcraftCore/src/org/workcraft/plugins/serialisation/xml/FileDeserialiser.java (+2/-1)
WorkcraftCore/src/org/workcraft/plugins/serialisation/xml/FileSerialiser.java (+3/-1)
WorkcraftCore/src/org/workcraft/workspace/WorkspaceEntry.java (+1/-1)
build_distr_linux.sh (+1/-1)
build_distr_windows.sh (+1/-1)
To post a comment you must log in.