PureISCSIDriver's log statements had a bad merge resolution

Bug #1395060 reported by Patrick East
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Patrick East

Bug Description

Changes from:

https://git.openstack.org/cgit/openstack/cinder/commit/?id=dbd111f87deb9a4636e466b9d75c76bf981cf8e5
https://review.openstack.org/134918

reverted the fixes to our log statements from a slightly early change:

https://review.openstack.org/#/c/135047/
https://git.openstack.org/cgit/openstack/cinder/commit/?id=1ebe1bddd0a02e9efaa05c8ec9d71a299b6877e1

We should put back in the changes that got reverted so we do not use .format() anywhere in the code... This will address the issues raised here:

https://review.openstack.org/#/c/135816/

Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136417

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/136417
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8d29321d2505590e4d6f649933d95ad895dd8c54
Submitter: Jenkins
Branch: master

commit 8d29321d2505590e4d6f649933d95ad895dd8c54
Author: Patrick East <email address hidden>
Date: Fri Nov 21 08:39:45 2014 -0800

    Fixup regressions in PureISCSIDriver log statements.

    There were some conflicting patches that went in to fix i18n helpers,
    and in the merge resolution we lost some changes that previously removed
    all uses of .format() from the driver. This puts back in the updated
    log statements originally added in
    https://review.openstack.org/#/c/135047/

    Change-Id: I562a0dd950b88af2bdb67a135f6f6f0d258eed0e
    Closes-Bug: 1395060

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.