Ironic

Set info = _parse_driver_info(self.node) in setup rather than in testcases.

Bug #1394910 reported by Harshada Mangesh Kakad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Undecided
Harshada Mangesh Kakad
Ironic 2015.1.0 "kilo"

Bug Description

In test_seamicro.py file almost all the testcases is using local variable info = _parse_driver_info(self.node). Ideally it should be set in setup only once, and use self.info in testcases.

Harshada Mangesh Kakad (harshada-kakad)
Changed in ironic:
assignee: nobody → Harshada Mangesh Kakad (harshada-kakad)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136274

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/136274
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=ccef54692cdd6dc16465d1b2c56e9c2821c2d737
Submitter: Jenkins
Branch: master

commit ccef54692cdd6dc16465d1b2c56e9c2821c2d737
Author: Harshada Mangesh Kakad <email address hidden>
Date: Fri Nov 21 01:28:31 2014 -0800

    Avoid calling _parse_driver_info in every test

    In test_seamicro.py file almost all the testcases are calling
    _parse_driver_info. Ideally it should be set in setup only once.

    Change-Id: Ic7daa4e8daec891380b1ead6824214abff28fbb6
    Closes-Bug: #1394910

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.