neutron

test_validate_nameservers fails on some platforms

Bug #1394867 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
YAMAMOTO Takashi
neutron 2015.1.0 "kilo"
Juno
Fix Released
Undecided
Stephen Ma
neutron 2014.2.3

Bug Description

the recently added '1'*59 case fails on some platforms because it's considered a valid ipv4 address by inet_aton.
eg. NetBSD, OS X

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136238

Changed in neutron:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/136238
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2794bb89d664355ae1194a0b1f8346c1538caef8
Submitter: Jenkins
Branch: master

commit 2794bb89d664355ae1194a0b1f8346c1538caef8
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 21 14:16:03 2014 +0900

    attributes: Additional IP address validation

    Introduce an additional IP address validation instead of assuming
    that netaddr provides it. Namely, it ensures that an address
    either has ':' (IPv6) or 3 periods like 'xx.xx.xx.xx'. (IPv4)

    The "'1' * 59" test case recently introduced by
    commit 1681f62ec91b6c3705a14393815542dc1746de71 fails on
    some platforms because it's considered a valid address by
    their inet_aton. Examples of such platforms: NetBSD, OS X

    While one might argue it's a fault of the platforms, this is
    a historical behavior which is probably too late to change there.

    (The breakage has been hidden by later UT changes in
    commit 35662d07628452d14306f5197871ad64f6396ff3 .
    This commit includes a UT change to uncover the problem again.)

    Closes-Bug: #1394867
    Related-Bug: #1378450
    Change-Id: Ibe02f8b7c4d437bf7abbe7304ca138bdcf4bfdb9

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Stephen Ma (stephen-ma)
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/161930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/161930
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d329c221c37714f1ce306918de8367dd948ec220
Submitter: Jenkins
Branch: stable/juno

commit d329c221c37714f1ce306918de8367dd948ec220
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Nov 21 14:16:03 2014 +0900

    attributes: Additional IP address validation

    Introduce an additional IP address validation instead of assuming
    that netaddr provides it. Namely, it ensures that an address
    either has ':' (IPv6) or 3 periods like 'xx.xx.xx.xx'. (IPv4)

    The "'1' * 59" test case recently introduced by
    commit 1681f62ec91b6c3705a14393815542dc1746de71 fails on
    some platforms because it's considered a valid address by
    their inet_aton. Examples of such platforms: NetBSD, OS X

    While one might argue it's a fault of the platforms, this is
    a historical behavior which is probably too late to change there.

    (The breakage has been hidden by later UT changes in
    commit 35662d07628452d14306f5197871ad64f6396ff3 .
    This commit includes a UT change to uncover the problem again.)

    (cherry-picked from 2794bb89d664355ae1194a0b1f8346c1538caef8)
    Closes-Bug: #1394867
    Related-Bug: #1378450
    Change-Id: Ibe02f8b7c4d437bf7abbe7304ca138bdcf4bfdb9

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.