check-tempest-dsvm-neutron-dvr failure after the recent rpc change

Bug #1394848 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Armando Migliaccio

Bug Description

http://logs.openstack.org/00/130300/6/check/check-tempest-dsvm-neutron-dvr/3b08db3/logs/screen-q-vpn.txt.gz?level=TRACE

FWaaSL3PluginApi assumes FWaaSPluginApiMixin still has call method from RpcProxy.

the problem introduced by https://review.openstack.org/#/c/135311/

Changed in neutron:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/136248

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :
Changed in neutron:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/136470

Changed in neutron:
assignee: Armando Migliaccio (armando-migliaccio) → Russell Bryant (russellb)
Revision history for this message
Russell Bryant (russellb) wrote :

Sorry about this. It's hard to track all of this down with how mixins are used all over the place. I'm relying pretty heavily on test coverage to find this stuff.

tags: added: l3-dvr-backlog
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Russell Bryant (<email address hidden>) on branch: master
Review: https://review.openstack.org/136470
Reason: Covered in https://review.openstack.org/#/c/136248/

Changed in neutron:
assignee: Russell Bryant (russellb) → Armando Migliaccio (armando-migliaccio)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/136248
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eff0b35013a8f02897ec428aebfcb4c8212f0b8d
Submitter: Jenkins
Branch: master

commit eff0b35013a8f02897ec428aebfcb4c8212f0b8d
Author: armando-migliaccio <email address hidden>
Date: Thu Nov 20 22:15:34 2014 -0800

    Fix AttributeError in RPC code for DVR

    Fix the usage of call methods as per recent changes according to
    drop-rpc-compat. These changes went overlooked and it broke DVR.

    Tests will be done as follow-up.

    Partial-bug: #1394848

    Change-Id: I6e0584f8e54e606a76b87853b2371cc8e24eba69

Changed in neutron:
importance: Critical → High
Changed in neutron:
importance: High → Low
Kyle Mestery (mestery)
Changed in neutron:
milestone: kilo-1 → kilo-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143778

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/143778

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/150179

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.openstack.org/150179
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=97f28d24450d27d3326334bce0dbba0dbbd28cbe
Submitter: Jenkins
Branch: master

commit 97f28d24450d27d3326334bce0dbba0dbbd28cbe
Author: armando-migliaccio <email address hidden>
Date: Tue Dec 23 22:30:19 2014 -0800

    Fix AttributeError when using DVRServerRpcApi

    This time with tests for the joy of Maru and Assaf. More
    context on [1].

    [1] https://review.openstack.org/#/c/143778/

    Related-bug: #1394848
    Closes-bug: #1414812

    Change-Id: I8ad1f1ad6caaee1f18a44f06cea532f4aa9a82b6

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.