Default guest_config attribute value points to invalid location

[Denis M.]

Default guest_config attribute value points to invalid location.

Here you can see that it points to '$pybasedir/etc/trove/trove-guestagent.conf.sample' - https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L344-L346

And it doesn't working out of box. Default value should point to /etc/trove/trove-guestagent.conf

Explanation:

Each Trove service looks up for its config config file at /etc/trove/*.conf
Templates by the default are available at /etc/trove/templates/

and so on.

[Robert Myers (rmyers)]

Technically you are correct, however I think it is done this way so that it works on a test vm. Possibly there is a better way, but not sure if changing the default will work on a devstack install. Please try it and report back.

[Denis M. (dmakogon)]

Robert, if you'd take a look at redstack installation, guest log lives in /etc/trove/trove-guestagent.conf

[Denis M. (dmakogon)]

To make my words more valueable/meaningful:

ubuntu@ubuntu:/opt/stack/trove$ cd
ubuntu@ubuntu:~$ ll /etc/trove/
total 40
drwxr-xr-x 2 ubuntu ubuntu 4096 Nov 19 10:36 ./
drwxr-xr-x 137 root root 12288 Nov 20 12:35 ../
-rw-r--r-- 1 ubuntu ubuntu 1596 Nov 19 10:32 api-paste.ini
-rw-rw-r-- 1 ubuntu ubuntu 3292 Nov 19 10:35 test.conf
-rw-r--r-- 1 ubuntu ubuntu 890 Nov 19 10:32 trove-conductor.conf
-rw-r--r-- 1 ubuntu ubuntu 774 Nov 19 10:36 trove.conf
-rw-r--r-- 1 ubuntu ubuntu 900 Nov 19 10:32 trove-guestagent.conf
-rw-r--r-- 1 ubuntu ubuntu 921 Nov 19 10:32 trove-taskmanager.conf
ubuntu@ubuntu:~$

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/148550

[OpenStack Infra (hudson-openstack)]

Change abandoned by Denis M. (<email address hidden>) on branch: master
Review: https://review.openstack.org/148550
Reason: in favor of https://review.openstack.org/#/c/100381/