Use session in cinderclient

[OpenStack Infra]

https://review.openstack.org/131098
commit 49192695423b949be0e914dee47695db30636280
Author: Jamie Lennox <email address hidden>
Date: Fri Aug 29 13:28:06 2014 +1000

    Use session in cinderclient

    Use the common session loading parameters and the session object for
    talking to cinder.

    There are some related changes in this patch.

    Firstly auth_token middleware now provides an authentication plugin that
    can be used along with the session object to make requests under the
    user's authentication. This will largely replace the information
    required on the context object.

    This authentication plugin is not serializable though and so it cannot
    be transferred over RPC so we introduce a simple authentication plugin
    that reconstructs the required information from the context.

    When talking to cinder we now create a global session object (think of
    this like keeping open a connection pool object) and use the
    authentication plugin to send requests to cinder.

    I also condense the cinder tests as they are largely copied and pasted
    between v1 and v2 and this solves fixing them in two places.

    DocImpact: Renames cinder's timeout, insecure and CA certificates
    parameters to the parameters used by the common session object. Adds
    options for using client certificates with connection.

    Change-Id: I7afe604503b8597c16be61d2a66a10b94269a219

[Jamie Lennox (jamielennox)]

Part of the purpose of this change is to standardize option names in only one place. This will happen in nova for neutron and hopefully soon wherever one service talks to another.

You can see the current list of options that are supported: https://github.com/openstack/python-keystoneclient/blob/1d72f2aa50babf52bbdefb035c5bcbfdccc1b57f/keystoneclient/session.py#L581

Hopefully it is reasonably easy to see what the old name and new names of the options are from the code as well.

Looking near the top of https://review.openstack.org/#/c/131098/9/nova/volume/cinder.py we can see that:

http_timeout was renamed simply timeout.
ca_certificates_file renamed cafile.
api_insecure renamed to insecure.

[Anne Gentle (annegentle)]

I am trying to triage this bug further.

http_timeout for cinder is documented in the Juno Config Ref for the nova.conf file
ca_certificates_file for cinder is documented in the Juno Config Ref for the nova.conf file
api_insecure for cinder is documented in the Juno Config ref for the nova.conf file
in: http://docs.openstack.org/juno/config-reference/content/list-of-compute-config-options.html

These are also listed as new configuration options for nova.conf in http://docs.openstack.org/juno/config-reference/content/nova-conf-changes-juno.html

So I believe this bug is fixed in the Juno release.

[Anne Gentle (annegentle)]

That said, the commit message is a bit of a red herring for finding what doc impact matters, as we wouldn't document the code-level details about auth sessions. So just noting that for future reference.