Tempo jumps random with the first track after start

Bug #1394372 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Owen Williams

Bug Description

Start Mixxx
Enable sync on an empty deck
Load a track
Track jumps to a random value.

Of cause this is a user error, but I think the master clock should just adapt the standard tempo of the track
as if the Sync button where pressed after the deck is loaded.

Tags: sync
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hm, not sure if i'd call that user error... we have various code for adding a follower when no other followers are active to make the internal clock adopt the follower's tempo. Maybe we need something like that when a track is loaded when the follower is the only follower?

Changed in mixxx:
milestone: none → 1.12.0
tags: added: sync
Revision history for this message
Owen Williams (ywwg) wrote :

master sync is supposed to take the bpm of a lone deck if no other deck is loaded. there are tests for this, weird that it's broken,

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

I think that logic is in the follower-enable code? Which if the sync is enabled before loading a track would not run that.

Revision history for this message
Owen Williams (ywwg) wrote :

it's hooked up to listen for track loads, so that should work.

Revision history for this message
Owen Williams (ywwg) wrote :

ah, it listens for a track playing, not loading. Ok I can fix it.

Revision history for this message
Owen Williams (ywwg) wrote :

ok I was able to fix it, but actually creating a test for it will be tricky :)

Revision history for this message
Owen Williams (ywwg) wrote :
Changed in mixxx:
status: New → Fix Committed
assignee: nobody → Owen Williams (ywwg)
importance: Undecided → Medium
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7665

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.