oslo.db release breaks sample config

Bug #1393559 reported by Steven Hardy
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steven Hardy
Juno
Fix Released
Undecided
Unassigned

Bug Description

oslo.db just released a new version, it's broken our sample conf:

2014-11-17 17:45:21.800 | --- /tmp/heat.XJCXuh/heat.conf.sample 2014-11-17 17:45:21.779176070 +0000
2014-11-17 17:45:21.800 | +++ etc/heat/heat.conf.sample 2014-11-17 17:42:29.547971000 +0000
2014-11-17 17:45:21.800 | @@ -892,9 +892,8 @@
2014-11-17 17:45:21.800 | # Deprecated group/name - [DATABASE]/sql_max_pool_size
2014-11-17 17:45:21.800 | #max_pool_size=<None>
2014-11-17 17:45:21.800 |
2014-11-17 17:45:21.801 | -# Maximum number of database connection retries during
2014-11-17 17:45:21.801 | -# startup. Set to -1 to specify an infinite retry count.
2014-11-17 17:45:21.801 | -# (integer value)
2014-11-17 17:45:21.801 | +# Maximum db connection retries during startup. Set to -1 to
2014-11-17 17:45:21.801 | +# specify an infinite retry count. (integer value)
2014-11-17 17:45:21.801 | # Deprecated group/name - [DEFAULT]/sql_max_retries
2014-11-17 17:45:21.801 | # Deprecated group/name - [DATABASE]/sql_max_retries
2014-11-17 17:45:21.801 | #max_retries=10
2014-11-17 17:45:21.801 | check_uptodate.sh: heat.conf.sample is not up to date.
2014-11-17 17:45:21.801 | check_uptodate.sh: Please run /home/jenkins/workspace/gate-heat-pep8/tools/config/generate_sample.sh.

Steven Hardy (shardy)
Changed in heat:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135081

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/135081
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c0f8529dabbf064bb582d5b10e032070f90ccc89
Submitter: Jenkins
Branch: master

commit c0f8529dabbf064bb582d5b10e032070f90ccc89
Author: Steven Hardy <email address hidden>
Date: Mon Nov 17 21:00:12 2014 +0000

    Update sample conf for new oslo.db release

    oslo.db just released a new version, and it's broken our gate config
    check, so update it.

    Change-Id: I0d077d0f55fbc2ab9faac5ff9deaadba00452869
    Closes-Bug: #1393559

Changed in heat:
status: In Progress → Fix Committed
Steven Hardy (shardy)
Changed in heat:
milestone: none → kilo-1
Revision history for this message
Matt Riedemann (mriedem) wrote :
Revision history for this message
Steven Hardy (shardy) wrote :

Given that we're moving to a model where we no longer control the timing of oslo updates, it probably makes sense for us (and other projects) to stop including a statically generated config in the tree, e.g include a README instead like nova already does.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135363

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/135363
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=699cc6251501638759177fe83b4090faeb88e0e5
Submitter: Jenkins
Branch: stable/juno

commit 699cc6251501638759177fe83b4090faeb88e0e5
Author: Steven Hardy <email address hidden>
Date: Mon Nov 17 21:00:12 2014 +0000

    Update sample conf for new oslo.db release

    oslo.db just released a new version, and it's broken our gate config
    check, so update it.

    Change-Id: I0d077d0f55fbc2ab9faac5ff9deaadba00452869
    Closes-Bug: #1393559
    (cherry picked from commit c0f8529dabbf064bb582d5b10e032070f90ccc89)

tags: added: in-stable-juno
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.