New fines generated on lost return exceed max fine amount

[Kathy Lussier]

Evergreen version: master

When the "Lost Checkin Generates New Overdues" setting is enabled, the fines that are added to a transaction upon a lost checkin can exceed the max fines amount.

I've only see this problem in master. The below test works as expected in a 2.7.1 system.

Relevant settings:
• Void overdue fines when item is marked lost - true
• Restore overdues on lost item return – true
• Lost checkin generates new overdues - true

This test was done on a transaction that accrued $2.40 in overdue fines before it was automatically set to the lost by the system. The transaction had a $3 max fines amount. On 11/14/2013, the overdue fines were voided, and the system assessed a $20 lost materials fee.

The item was then returned on 11/17/14. The previous overdue fines were restored (no longer voided), the lost materials fee was voided, and then another $6 in fines was added to the record. No payments have been made on this transaction. Therefore the patron now owes $8.40 for this transactions.

The $6 in fines accrued over 60 days where we are seeing two $.05 fines added per day. The screenshot at http://www.screencast.com/t/fUKkwyqX shows the display in the staff client at the point where you can see the pre-lost overdue fines followed by the voided lost fee and then the new overdue fines that are duplicating each day.

Since this problem is only showing up in master, my guess is it was introduced either through http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e1fdcd3a6885baac3f86402e330aef3d8b36c681 or http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d2a521c0ff32e9921bfc93cb86b2c917e5eda92e

[Dan Wells (dbw2)]

Okay, I was hoping for simple fix, but there isn't one. Since I pushed them in, I am simply reverting the two mentioned commits for now.