`bzr send` failed with UnicodeEncodeError

Bug #139318 reported by Alexander Belchenko
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Alexander Belchenko

Bug Description

I want to send the patch to my co-worker. Last log message contains russian text. Because `bzr send --mail-to` pass last log message as subject line to mail client it fails on win32:

bzr: ERROR: exceptions.UnicodeEncodeError: 'ascii' codec can't encode characters in position 132-140: ordinal not in range(128)

Traceback (most recent call last):
  File "bzrlib\commands.pyc", line 800, in run_bzr_catch_errors
  File "bzrlib\commands.pyc", line 758, in run_bzr
  File "bzrlib\commands.pyc", line 492, in run_argv_aliases
  File "bzrlib\builtins.pyc", line 3904, in run
  File "bzrlib\builtins.pyc", line 4000, in _run
  File "bzrlib\mail_client.pyc", line 68, in compose_merge_request
  File "bzrlib\mail_client.pyc", line 129, in compose
  File "bzrlib\mail_client.pyc", line 149, in _compose
  File "subprocess.pyc", line 443, in call
  File "subprocess.pyc", line 593, in __init__
  File "subprocess.pyc", line 815, in _execute_child
UnicodeEncodeError: 'ascii' codec can't encode characters in position 132-140: ordinal not in range(128)

bzr 0.91.0candidate2 on python 2.5.1.final.0 (win32)
arguments: ['D:\\Program Files\\Bazaar\\bzr.EXE', 'send', '--mail-to', '<email address hidden>']

Invoking program via subprocess module require to pass all command arguments encoded in default windows encoding, i.e. in bzrlib.user_encoding.

Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Alexander Belchenko (bialix) wrote :

I don't use Linux to send patches so I don't know is this bug related to Linux. So I'll try to fix it for Windows only. If someone else encounter this bug on Linux -- it should be filed as another bug.

Changed in bzr:
assignee: nobody → bialix
milestone: none → 1.3
status: Confirmed → In Progress
Revision history for this message
Alexander Belchenko (bialix) wrote :

patch sent to ML.

Changed in bzr:
status: In Progress → Fix Committed
Changed in bzr:
status: Fix Committed → In Progress
Revision history for this message
Alexander Belchenko (bialix) wrote :

patch sent to ML. awaiting approval.

Changed in bzr:
status: In Progress → Fix Committed
milestone: 0.9a → 1.3
Revision history for this message
Alexander Belchenko (bialix) wrote :

merged as revno.3267

Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.