ResourceGroup updates don't work from size=0

Bug #1392796 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steven Hardy
Juno
Fix Released
High
Steven Hardy

Bug Description

If you create a resource group of provider resources, with an initial size of zero, then update it, the update fails because there's no nested stack to update.

Steven Hardy (shardy)
Changed in heat:
assignee: nobody → Steven Hardy (shardy)
tags: added: tripleo
Changed in heat:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135031

Changed in heat:
status: Triaged → In Progress
Steven Hardy (shardy)
Changed in heat:
milestone: none → kilo-1
Steven Hardy (shardy)
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/135031
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d73107bd35cadcad0b4933aec43ef0313b961a45
Submitter: Jenkins
Branch: master

commit d73107bd35cadcad0b4933aec43ef0313b961a45
Author: Steven Hardy <email address hidden>
Date: Mon Nov 17 17:38:32 2014 +0000

    ResourceGroup don't special-case zero count

    Currently, when you specify an initial count of zero, we don't
    create the nested stack. Unfortunately this then means you can
    never update it, which makes the group forever broken..

    Instead, always create the stack on create, even if it's an empty
    stack containing zero resources. This allows subsequent updates
    which move to a non-zero count to work as expected.

    Change-Id: I494229fcf85a1c28428fa2925c060fc1f40f4f36
    Closes-Bug: #1392796

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135673

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/135673
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6958217259286f56deba87b941609aca887ec6f5
Submitter: Jenkins
Branch: stable/juno

commit 6958217259286f56deba87b941609aca887ec6f5
Author: Steven Hardy <email address hidden>
Date: Mon Nov 17 17:38:32 2014 +0000

    ResourceGroup don't special-case zero count

    Currently, when you specify an initial count of zero, we don't
    create the nested stack. Unfortunately this then means you can
    never update it, which makes the group forever broken..

    Instead, always create the stack on create, even if it's an empty
    stack containing zero resources. This allows subsequent updates
    which move to a non-zero count to work as expected.

    Change-Id: I494229fcf85a1c28428fa2925c060fc1f40f4f36
    Closes-Bug: #1392796
    (cherry picked from commit d73107bd35cadcad0b4933aec43ef0313b961a45)

tags: added: in-stable-juno
no longer affects: heat/kilo
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
Zane Bitter (zaneb)
tags: removed: juno-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.