Cinder

iSCSI CHAP credentials length issue

Bug #1392792 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Lucian Petrut
Cinder 2015.1.0 "kilo"
Juno
Fix Released
Undecided
Unassigned
Cinder 2014.2.1

Bug Description

Some of the iSCSI initiators have a limit regarding the maximum CHAP credentials length. For example, the MS iSCSI Initiator cannot use CHAP credentials longer than 16 characters, smaller than the actual default 20 characters length.

For this reason, a config option must be added in order to specify the CHAP credentials length.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134592

Changed in cinder:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/136535

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/134592
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3e124edb5dbbd5b48bb8816e6c1b60f5a0fa03db
Submitter: Jenkins
Branch: master

commit 3e124edb5dbbd5b48bb8816e6c1b60f5a0fa03db
Author: Lucian Petrut <email address hidden>
Date: Fri Nov 14 18:22:04 2014 +0200

    Change CHAP secret default length

    Some of the iSCSI initiators have a limit regarding the maximum
    CHAP secret length. For example, the MS iSCSI Initiator
    does not allow CHAP secrets longer than 16 characters, smaller
    than the actual default 20 characters length.

    This patch simply changes the default length to 16 characters,
    value which is already used by default by some of the volume
    drivers. In fact, the iSCSI specs state that: "Implementations
    MUST support use of up to 128 bit random CHAP secrets".

    Change-Id: I0295fabd0c0048c93e1f452077d0f5d19af9784d
    Closes-Bug: #1392792

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/juno)

Reviewed: https://review.openstack.org/136535
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7b1d7a31335bd8723551c9af5c270927ad830c3f
Submitter: Jenkins
Branch: stable/juno

commit 7b1d7a31335bd8723551c9af5c270927ad830c3f
Author: Lucian Petrut <email address hidden>
Date: Fri Nov 14 18:22:04 2014 +0200

    Change CHAP secret default length

    Some of the iSCSI initiators have a limit regarding the maximum
    CHAP secret length. For example, the MS iSCSI Initiator
    does not allow CHAP secrets longer than 16 characters, smaller
    than the actual default 20 characters length.

    This patch simply changes the default length to 16 characters,
    value which is already used by default by some of the volume
    drivers. In fact, the iSCSI specs state that: "Implementations
    MUST support use of up to 128 bit random CHAP secrets".

    Change-Id: I0295fabd0c0048c93e1f452077d0f5d19af9784d
    Closes-Bug: #1392792
    (cherry picked from commit 3e124edb5dbbd5b48bb8816e6c1b60f5a0fa03db)

tags: added: in-stable-juno
Mike Perez (thingee)
Changed in cinder:
importance: Undecided → Low
Mike Perez (thingee)
Changed in cinder:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.