Admins cannot access the default pool through the API

Bug #1392748 reported by Betsy Luzader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Betsy Luzader

Bug Description

A Designate admin is not able to access the default pool through the public API calls. The default pool is created with a tenant_id of null. The query to GET the pool does not match the 'WHERE tenant_id is ?' clause, so it does not result in a match.

The fix is to modify the _apply_tenant_criteria method in the designate/sqlalchemy/base.py module to also accept tenant_id = NULL.

Changed in designate:
importance: Undecided → Critical
assignee: nobody → Betsy Luzader (betsy-luzader)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134653

Changed in designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/134653
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=813843bd366933224e65e54519ba0a3eb08dd8c3
Submitter: Jenkins
Branch: master

commit 813843bd366933224e65e54519ba0a3eb08dd8c3
Author: Betsy Luzader <email address hidden>
Date: Fri Nov 14 15:13:51 2014 -0600

      Can't Access Default Pool through API

      Since the default pool had a tenant_id = Null, not even an
      admin could access it through the API. This fixes that.

      Closes-Bug:#1392748

    Change-Id: I5238b119ee62dc168ac3bfc5875619c1e07eac60

Changed in designate:
status: In Progress → Fix Committed
Kiall Mac Innes (kiall)
Changed in designate:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.