Documentation error in base tables

[Marcos Lobo]

In /horizon/tables/base.py there is a mistake in the documentation here: https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L197

"An iterable of CSS classes which will be added when the column's text
is displayed as a link.
This is left for backward compatibility. Deprecated in favor of the
link_attributes attribute.
Example: ``classes=('link-foo', 'link-bar')``.
Defaults to ``None``"

The name of the attribute is "link_classes", not "classes" like the example suggests. That could be confusing for developers.

For example, if you modify openstack-dashboard/dashboards/project/images/images/tables.py file and add this:

name = tables.Column(get_image_name_version,
                         link=("horizon:project:images:images:detail"),
                         verbose_name=_("Image Name"),
                         classes=("css-foo","css-bar"))

You expect something like:

<a href="whatever" class="css-foo css-bar">my name</a>

But doesn't work.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/134526

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/134526
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6df5616551b6c31081d36fd68a79eefb5143c391
Submitter: Jenkins
Branch: master

commit 6df5616551b6c31081d36fd68a79eefb5143c391
Author: Marcos Fermin Lobo <email address hidden>
Date: Fri Nov 14 14:14:35 2014 +0100

    Documentation error in base tables link_classes

    In /horizon/tables/base.py there is a mistake in the
    documentation here:
    https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L197

    The name of the attribute is "link_classes", not
    "classes" like the example suggests. That could be confusing for developers.

    Change-Id: I61c1807f61364a152a5a51fcec8e9158dfa7067c
    Closes-Bug: #1392721