BandwidthUsage.create() used incorrectly in _poll_bandwidth_usage

[Andrew Laski]

2014-11-13 06:30:32.010 21838 ERROR nova.openstack.common.periodic_task [-] Error during ComputeManager._poll_bandwidth_usage: unbound method create() must be called with BandwidthUsage instance as first argument (got RequestContext instance instead)

is being raised during the _poll_bandwidth_usage periodic task if reporting is supported. It is not showing up in the gate because this capability is set to be unsupported there. The cause is that create() is used as a classmethod though it is not defined as one.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/134323

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/134323
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=31f05239d2ac0407be23e3d6bc5f5df9aa53f100
Submitter: Jenkins
Branch: master

commit 31f05239d2ac0407be23e3d6bc5f5df9aa53f100
Author: Andrew Laski <email address hidden>
Date: Thu Nov 13 13:03:04 2014 -0500

    Fix usage of BandwidthUsage.create()

    The _poll_bandwidth_usage periodic task was attempting to use
    BandwidthUsage as a classmethod even though it is not defined as a
    classmethod. It has been updated to be used properly and a test was
    added to ensure there is no error.

    Change-Id: I96709675a952857da5121da29acd1ab2e6726fd0
    Closes-Bug: #1392423