hanging mount points when building iso

[Aleksandra Fedorova]

Following paths are left mounted on a build server after build iso tasks finished

home/jenkins/workspace/tmp/master.iso/local_mirror/centos/os/x86_64 on /home/jenkins/workspace/tmp/master.iso/build/image/centos/SANDBOX/mirror type none (rw,bind)
/home/jenkins/workspace/tmp/6.0.staging.iso/local_mirror/centos/os/x86_64 on /home/jenkins/workspace/tmp/6.0.staging.iso/build/image/centos/SANDBOX/mirror type none (rw,bind)
/home/jenkins/workspace/tmp/6.0.staging.iso/local_mirror on /home/jenkins/workspace/tmp/6.0.staging.iso/build/image/tmp/ubuntu_chroot/tmp/mirror type none (rw,bind)
/home/jenkins/workspace/tmp/master.staging.iso/local_mirror/centos/os/x86_64 on /home/jenkins/workspace/tmp/master.staging.iso/build/image/centos/SANDBOX/mirror type none (rw,bind)
/home/jenkins/workspace/tmp/6.0.iso/local_mirror/centos/os/x86_64 on /home/jenkins/workspace/tmp/6.0.iso/build/image/centos/SANDBOX/mirror type none (rw,bind)

make deep_clean seems to unmount only local_mirror/ubuntu mountpoints leaving all centos ones.

[Alexander Gordeev (a-gordeev)]

how to reproduce:

1) insert 'exit 1' before `umount` https://github.com/stackforge/fuel-main/blob/master/image/ubuntu/create_separate_images.sh#L136
2) run 'make target_ubuntu_image' (it's faster than full iso rebuilding)
3) wait until it get failed on that line.
4) 'make deep_clean' will leave ubuntu mirror and the root fs image mounted. Run build again and it will produce this err http://jenkins-product.srt.mirantis.net:8080/job/6.0.iso/94/console
5) manually umount ubuntu mirror. 'make deep_clean' again and build then will produce this err http://jenkins-product.srt.mirantis.net:8080/job/6.0.iso/96/console

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/134029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/134029
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=03561abb53afd226b9ef8b64e94fa73d8f045a58
Submitter: Jenkins
Branch: master

commit 03561abb53afd226b9ef8b64e94fa73d8f045a58
Author: Alexander Gordeev <email address hidden>
Date: Wed Nov 12 21:27:34 2014 +0300

    Fix hanging mount points issues

    Mainly fixes the building of target ubuntu image.
    Just a couple of minor things like:
    1) unreachable lazy umount due to `echo` return code
    2) non removing of dissociated loop device
    3) forgotten mirror unmounting

    Change-Id: Ib991ebe31aa4b7a9f421a38d1dfee3d886177906
    Closes-Bug: #1391896